test,n-api: delete strong ref w/o unrefing first

[gabrielschulhof]

Fixes: #34731
Signed-off-by: @gabrielschulhof

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[addaleax]

It's great that this fixes the test, but it still seems counterintuitive that unref'ing a reference can lead to a memory leak? I would not say that this "Fixes:" the issue.

[gabrielschulhof]

@addaleax you're right. We should either document that strong references must not be weakened before getting deleted or figure out how to accommodate weakening them before deletion. I'll replace the "Fixes" with "Re".

[mhdawson]

I agreed and unless there is some V8 level limitation I think it should be figure out how to accommodate weakening them before deletion.

[mhdawson]

I'd also lean towards not landing this until we better understand the issue, as it provides the reminder that we need to fix the underlying problem.

[addaleax]

I'm personally okay with landing this, if you like.

(Edit: Btw, we use Refs: for referencing issues in commit messages almost universally at this point. The commit message linter might expect that as well, I’m not sure.)