Conversation
nodejs-github-bot
added
the
meta
AUTHORS
Outdated
| ExE Boss <3889017+ExE-Boss@users.noreply.github.com> | ||
| Mateusz Krawczuk <krawczukmat@gmail.com> | ||
| Jonathan MERCIER <jmercier@cng.fr> | ||
| Ujjwal Sharma <ryzokuken@igalia.com> |
There was a problem hiding this comment.
This is definitely a duplicate. Please remove it and update .mailmap. Did you check if there are more?
There was a problem hiding this comment.
@lpinca This email is also not present in .mailmap should I update it in the .mailmap as well?
There was a problem hiding this comment.
I think the update-authors also need to change for this.
|
This could be automated by an Action. Any takers? |
|
@mmarchini I just used the script in the tools, will try to update the script so that this case doesn't occur and update the AUTHORS file. |
|
@yashLadha might be better to do @lpinca suggestion above for this PR and then open another one for changes on the script. |
AUTHORS
Outdated
| Alex R <alexei.rudenko@gmail.com> | ||
| Hachimi Aa (Sfeir) <hachimi.aa@sfeir.com> | ||
| Daniel Estiven Rico Posada <danielrico.posada@gmail.com> | ||
| Ruben Bridgewater <ruben.bridgewater@maibornwolff.de> |
There was a problem hiding this comment.
You also need to add this email address to the .mailmap, otherwise it will show up again during the next update
|
Okay @mmarchini Will remove the duplicates. |
richardlau
left a comment
richardlau
left a comment
There was a problem hiding this comment.
More duplicates. These should be handled by:
- Adding the entries to
.mailmap - Rerunning the generator script
| Bartlomiej Brzozowski <bart.brzozowski@janeasystems.com> | ||
| Saajan <saajan.sn@gmail.com> | ||
| Yash Ladha <yashladhapankajladha123@gmail.com> | ||
| Xu Meng <dmabupt@gmail.com> |
| Kirill Shatskiy <shaackiy@gmail.com> | ||
| Ben Bucksch <ben.bucksch@beonex.com> | ||
| Eli Schwartz <eschwartz@archlinux.org> | ||
| Ash Cripps <ashley.cripps@ibm.com> |
| Johannes Schöpp <schoepp@rz.uni-frankfurt.de> | ||
| Francisco Ryan Tolmasky I <tolmasky@gmail.com> | ||
| Ye-hyoung Kang <keepyourhonor@gmail.com> | ||
| Myles Borins <mylesborins@github.com> |
|
I'm closing this as it was superseded by #35280. |
7 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes