build: do not run auto-start-ci on forks#34650
build: do not run auto-start-ci on forks#34650evanlucas wants to merge 1 commit intonodejs:masterfrom
Conversation
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node.
|
Can we instead check if the secrets are present, and if not skip the run? I'd like this to still work on forks since sometimes we test this kind of thing on nodejs/node-auto-tools. |
|
@mmarchini that's a good point. Lemme see what I can do |
|
|
||
| jobs: | ||
| startCI: | ||
| if: github.repository == 'nodejs/node' |
There was a problem hiding this comment.
| if: github.repository == 'nodejs/node' | |
| if: secrets.JENKINS_USER && secrets.JENKINS_TOKEN |
Also not sure if it works. Feel free to try on nodejs/node-auto-test first (I can re-enable Actions there, just give me a ping).
There was a problem hiding this comment.
It might need to be
| if: github.repository == 'nodejs/node' | |
| if: ${{ secrets.JENKINS_USER && secrets.JENKINS_TOKEN }} |
There was a problem hiding this comment.
https://github.xiaomo-station.topmunity/t/jobs-job-id-if-does-not-work-with-env-secrets/16928/5 It doesn't sound like it does work...
|
@evanlucas I re-enabled Actions on https://github.com/nodejs/node-auto-test. Let's test there first, since the Action is working here it's better if we're sure the changes will work. |
|
Sounds good. I'll open a PR over there. I think I've found a way to do it |
|
FWIW you should be able to test on a personal fork as well, just push the changes to master there :) |
mmarchini
left a comment
There was a problem hiding this comment.
Let's move forward with this approach for now, we can't use secrets on conditionals and even with workarounds to check if conditionals exist, cancelling the run will also trigger notifications.
|
fast track? |
|
Landed in ac5773b |
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Previously, the auto-start-ci action would run on forks. Without the secrets, the action would fail over and over again. This caused a lot of email spam. Now, we only run this action when the repository is nodejs/node. PR-URL: #34650 Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Previously, the auto-start-ci action would run on forks.
Without the secrets, the action would fail over and over again.
This caused a lot of email spam. Now, we only run this action
when the repository is nodejs/node.
/cc @mmarchini I think this should work, although I'm not sure how to test...
Checklist