Skip to content

n-api: simplify bigint-from-word creation#34554

Closed
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof:simplify-bigint-words
Closed

n-api: simplify bigint-from-word creation#34554
gabrielschulhof wants to merge 1 commit intonodejs:masterfrom
gabrielschulhof:simplify-bigint-words

Conversation

@gabrielschulhof
Copy link
Contributor

@gabrielschulhof gabrielschulhof commented Jul 29, 2020

Macro CHECK_MAYBE_EMPTY_WITH_PREAMBLE() does the work of checking
the TryCatch and returning napi_pending_exception so this change
reuses it for napi_create_bigint_words().

Signed-off-by: Gabriel Schulhof @gabrielschulhof

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

n-api: simplify bigint-from-word creation
540a08b 
Macro `CHECK_MAYBE_EMPTY_WITH_PREAMBLE()` does the work of checking
the `TryCatch` and returning `napi_pending_exception` so this change
reuses it for `napi_create_bigint_words()`.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
@gabrielschulhof gabrielschulhof requested a review from devsnek July 29, 2020 18:14
@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jul 29, 2020
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Jul 29, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 29, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32549/

MrCheater
MrCheater suggested changes Jul 30, 2020
View reviewed changes
src/js_native_api_v8.cc
*result = v8impl::JsValueFromV8LocalValue(b.ToLocalChecked());
return napi_clear_last_error(env);
}
CHECK_MAYBE_EMPTY_WITH_PREAMBLE(env, b, napi_generic_failure);
Copy link

@MrCheater MrCheater Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No tests - no pull-request

Copy link
Contributor Author

@gabrielschulhof gabrielschulhof Jul 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new test included with this PR tests the correct behaviour of CHECK_MAYBE_EMPTY_WITH_PREAMBLE().

mhdawson
mhdawson approved these changes Jul 30, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

gabrielschulhof pushed a commit that referenced this pull request Jul 31, 2020
n-api: simplify bigint-from-word creation
0cc2a54 
Macro `CHECK_MAYBE_EMPTY_WITH_PREAMBLE()` does the work of checking
the `TryCatch` and returning `napi_pending_exception` so this change
reuses it for `napi_create_bigint_words()`.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #34554
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@gabrielschulhof
Copy link
Contributor Author

gabrielschulhof commented Jul 31, 2020

Landed in 0cc2a54.

codebytere pushed a commit that referenced this pull request Aug 5, 2020
@codebytere
n-api: simplify bigint-from-word creation
2703fe4 
Macro `CHECK_MAYBE_EMPTY_WITH_PREAMBLE()` does the work of checking
the `TryCatch` and returning `napi_pending_exception` so this change
reuses it for `napi_create_bigint_words()`.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #34554
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@codebytere codebytere mentioned this pull request Aug 10, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@addaleax
n-api: simplify bigint-from-word creation
711ad82 
Macro `CHECK_MAYBE_EMPTY_WITH_PREAMBLE()` does the work of checking
the `TryCatch` and returning `napi_pending_exception` so this change
reuses it for `napi_create_bigint_words()`.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #34554
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@addaleax
n-api: simplify bigint-from-word creation
02fe750 
Macro `CHECK_MAYBE_EMPTY_WITH_PREAMBLE()` does the work of checking
the `TryCatch` and returning `napi_pending_exception` so this change
reuses it for `napi_create_bigint_words()`.

Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com>
PR-URL: #34554
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
@gabrielschulhof gabrielschulhof deleted the simplify-bigint-words branch January 28, 2021 00:14
@gabrielschulhof gabrielschulhof restored the simplify-bigint-words branch January 28, 2021 05:40
@gabrielschulhof gabrielschulhof deleted the simplify-bigint-words branch February 3, 2021 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@mhdawson mhdawson mhdawson approved these changes

@devsnek devsnek Awaiting requested review from devsnek

+1 more reviewer

@MrCheater MrCheater MrCheater requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@gabrielschulhof @nodejs-github-bot @jasnell @addaleax @MrCheater @mhdawson