docs: add missing shell option to execSync#3440
Closed
claudiorodriguez wants to merge 1 commit intonodejs:masterfrom
Closed
docs: add missing shell option to execSync#3440claudiorodriguez wants to merge 1 commit intonodejs:masterfrom
claudiorodriguez wants to merge 1 commit intonodejs:masterfrom
Conversation
mscdex
added
the
child_process
Member
|
LGTM |
Contributor
|
@jasnell LTS? |
Member
|
@thealphanerd ... +1 |
Contributor
|
LGTM |
Member
|
Nit: first line of commit log message should be less than 50 chars (no big deal if you don't fix it, whoever merges it can fix it, but you'd be saving someone a step) |
claudiorodriguez
changed the title
claudiorodriguez
force-pushed
the
doc-child-process-execsync-missing-shell-option
branch
from
e6f0852 to
1c2f9dd
Compare
Contributor
Author
|
@Trott Whoops, I'll have to keep that in mind. Fixed. Thanks! |
Member
|
Landed in 49f965c |
Member
|
Landed in v4.x-staging in 47ab7c7 |
This was referenced Nov 29, 2023
This was referenced Nov 29, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the "shell" option from child_process.exec to child_process.execSync on the api docs. Issue #3387