Revert "http2: streamline OnStreamRead streamline memory accounting"#34315
Closed
Trott wants to merge 0 commit intonodejs:masterfrom
Closed
Revert "http2: streamline OnStreamRead streamline memory accounting"#34315Trott wants to merge 0 commit intonodejs:masterfrom
Trott wants to merge 0 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
Collaborator
Member
Author
|
CI passed on the first try, so that's encouraging. I'm going to set up two CI jobs to confirm that this change fixes the flaky test. |
Member
Author
|
CI stress test with this change (should pass): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37209/ CI stress test on master branch without this change (should fail a lot): https://ci.nodejs.org/job/node-test-commit-windows-fanned/37210/ |
Member
Author
Results are as expected. |
Trott
added
the
author ready
devnexen
approved these changes
Jul 12, 2020
jasnell
approved these changes
Jul 12, 2020
lundibundi
approved these changes
Jul 12, 2020
Member
Author
|
Landed in e1b336f |
Merged
lundibundi
added a commit
to lundibundi/node
that referenced
this pull request
Jul 22, 2020
4 tasks
clshortfuse
pushed a commit
to clshortfuse/node
that referenced
this pull request
Oct 7, 2020
This reverts commit 51ccf1b. Fixes: nodejs#31089 PR-URL: nodejs#34315 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 51ccf1b.
Fixes: #31089
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes