doc/api: module syncBuiltinESMExports example fix#34284
Conversation
guybedford
left a comment
There was a problem hiding this comment.
Thanks @bmacnaughton for fixing this up!
|
Is there something I need to do in order to fix the failing checks? I see no errors in the output (and the example code in docs doesn't get executed afaict). Also, if there is any feedback for me regarding how I can improve PRs let me know. I'm a novice. |
|
The failure just seems to be some flakey tests on the GitHub CI process. No need to fix anything. |
|
@bmacnaughton can you rebase to resolve the conflicts please? |
|
This issue/PR was marked as stalled, it will be automatically closed in 30 days. If it should remain open, please leave a comment explaining why it should remain open. |
|
Closing this because it has stalled. Feel free to reopen if this PR is still relevant, or to ping the collaborator who labelled it stalled if you have any questions. |
|
Reopening as this is a valid docs bug we should fix. |
|
The diff here is exactly the same but against the |
b62c80b to
86f4429
Compare
Fix failing code and add explanations of each assert. PR-URL: nodejs#34284 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
86f4429 to
28e9c10
Compare
|
Landed in 28e9c10 |
Fix failing code and add explanations of each assert. PR-URL: #34284 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fix failing code and add explanations of each assert. PR-URL: #34284 Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Fix failing code and add explanations of each assert.
Checklist
Fix incorrect assert expectations, add explanation of what each assert is verifying.
Define assert so the example is self-contained.