build: remove unused flags in toolchain.gypi and node_gyp.py#34270
Closed
Nishikoh wants to merge 1 commit intonodejs:masterfrom
Nishikoh:clean-up-unused-flags
Closed
build: remove unused flags in toolchain.gypi and node_gyp.py#34270Nishikoh wants to merge 1 commit intonodejs:masterfrom Nishikoh:clean-up-unused-flags
Nishikoh wants to merge 1 commit intonodejs:masterfrom
Nishikoh:clean-up-unused-flags
Conversation
The `linux_use_gold_flag`, `linux_use_bundled_gold` and `linux_use_bundled_binutils` flags are unused and can be removed, our build always disables them. Removed them in `tools/v8_gypfiles/toolchain.gypi` and `/tools/gyp_node.py`. Fixes: #34256
nodejs-github-bot
added
build
Member
|
I'm afraid someone else beat you to it by two hours: #34268 |
Author
|
Well ... I was commenting and I tried to make sure it didn't happen ... #34256 (comment) |
Member
|
I believe this was superseded by #34268 which was landed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #34256
The
linux_use_gold_flag,linux_use_bundled_goldandlinux_use_bundled_binutilsflags are unused and can be removed, our build always disables them.Removed them in
tools/v8_gypfiles/toolchain.gypiand/tools/gyp_node.py.Checklist