doc: document security issues with url.parse()#34226
Closed
jasnell wants to merge 3 commits intonodejs:masterfrom
Closed
doc: document security issues with url.parse()#34226jasnell wants to merge 3 commits intonodejs:masterfrom
jasnell wants to merge 3 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
doc
bnoordhuis
approved these changes
Jul 7, 2020
Co-authored-by: Ben Noordhuis <info@bnoordhuis.nl>
addaleax
approved these changes
Jul 7, 2020
addaleax
added
the
author ready
trivikr
approved these changes
Jul 9, 2020
Trott
reviewed
Jul 9, 2020
Trott
reviewed
Jul 9, 2020
Trott
reviewed
Jul 9, 2020
Trott
reviewed
Jul 9, 2020
Trott
reviewed
Jul 9, 2020
Trott
previously requested changes
Jul 9, 2020
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
I've left a few suggestions and I'd consider two of them mandatory:
- Use
APIrather thanapi - Use
host namerather thanhostnamefor consistency with our other docs, UNIX man pages, and DNS specifications
Feel free to dismiss this once those things are updated. No need to wait for me to come back to the GitHub interface and do it.
Co-authored-by: Rich Trott <rtrott@gmail.com>
Member
Author
|
Landed in a95fb93 |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #31279
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes