tls: remove unnecessary close listener …

[ronag]

Wrapped streams are expected to behave the same as socket with handle.
Remove unnecessary difference in handling.

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• documentation is changed or added
• commit message follows commit guidelines

[ronag]

As a side note... there is a lot that could be improved in the tls code... However, it's kind of risky and difficult to work with. Is this something we would like to do or should I just leave it alone?

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32133/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32145/

[addaleax]

As a side note... there is a lot that could be improved in the tls code... However, it's kind of risky and difficult to work with. Is this something we would like to do or should I just leave it alone?

I think it’s similar to streams – it’s hard to work with until somebody puts in a lot of work to clear it up. :/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32147/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32173/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32174/

[ronag]

Landed in 60a217b

[panmenghan]

@ronag
This change causes the following code to crash.

const http2 = require('http2')
const net = require('net')
const {Duplex} = require('stream')

class JsSocket extends Duplex {
  constructor(socket) {
    super({autoDestroy: true, allowHalfOpen: false})
    socket.on('data', (data) => this.push(data))
    socket.on('end', (data) => this.push(null))
    socket.on('close', () => this.destroy())
    this.socket = socket
  }

  unref() {}
  ref() {}
  setNoDelay() {}
  setTimeout() {}

  _write(data, encoding, callback) {
    this.socket.write(data, encoding, callback)
  }

  _final(callback) {
    callback()
  }

  _read(size) {}

  _destroy(error, callback) {
    callback()
  }
}

const realSocket = net.connect({host: 'www.example.com', port: '443'},
  () => {
    console.log('connected')
    const connection = http2.connect('https://www.example.com', {
      socket: new JsSocket(realSocket), // crash!!!
      // socket: realSocket, // but not crash!!!
    })
    const h2Stream = connection.request({[http2.constants.HTTP2_HEADER_PATH]: '/'})
    setTimeout(() => {realSocket.destroy()}, 2e3)
    setTimeout(() => {connection.close()}, 3e3)
  }
)

output:

internal/js_stream_socket.js:210
    handle.finishWrite(req, errCode);
           ^

TypeError: Cannot read property 'finishWrite' of null
    at JSStreamSocket.finishWrite (internal/js_stream_socket.js:210:12)
    at Immediate.<anonymous> (internal/js_stream_socket.js:195:14)
    at processImmediate (internal/timers.js:461:21)