doc: make minor improvements to paragraph in child_process.md#34063
Merged
Trott merged 0 commit intonodejs:masterfrom Jun 29, 2020
Merged
doc: make minor improvements to paragraph in child_process.md#34063Trott merged 0 commit intonodejs:masterfrom
Trott merged 0 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
child_process
addaleax
approved these changes
Jun 26, 2020
doc/api/child_process.md
Outdated
Member
There was a problem hiding this comment.
I liked the “is considered to be an error” phrasing, because it hints at the fact that exit code 0 = success is just a convention and we can’t know whether there actually has been an error.
Member
Author
There was a problem hiding this comment.
Does this work?
By convention, any exit code other than `0` indicates an error.My thinking is that this states plainly that it's a convention, whereas "is considered" only hints at that.
Member
Author
|
@nodejs/documentation |
trivikr
approved these changes
Jun 28, 2020
lundibundi
approved these changes
Jun 28, 2020
Member
Author
|
Landed in 90d5f35 |
MylesBorins
pushed a commit
that referenced
this pull request
Jul 14, 2020
Use shorter and more direct phrasing. PR-URL: #34063 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jul 16, 2020
Use shorter and more direct phrasing. PR-URL: #34063 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Use shorter and more direct phrasing. PR-URL: #34063 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use shorter and more direct phrasing.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes