Skip to content

Revert "repl: always check for NODE_REPL_MODE environment variable"#34058

Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:revert-simplify-repl
Closed

Revert "repl: always check for NODE_REPL_MODE environment variable"#34058
addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax:revert-simplify-repl

Conversation

@addaleax
Copy link
Member

@addaleax addaleax commented Jun 26, 2020

This reverts commit b831b08.

This presumably unbreaks the ASAN github action build.

Example failure:

2020-06-25T19:59:15.1448178Z === release test-repl-envvars ===
2020-06-25T19:59:15.1448872Z Path: parallel/test-repl-envvars
2020-06-25T19:59:15.1449449Z --- stderr ---
2020-06-25T19:59:15.1449835Z assert.js:103
2020-06-25T19:59:15.1450194Z   throw new AssertionError(obj);
2020-06-25T19:59:15.1450524Z   ^
2020-06-25T19:59:15.1450817Z
2020-06-25T19:59:15.1451431Z AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
2020-06-25T19:59:15.1452000Z + actual - expected
2020-06-25T19:59:15.1452298Z
2020-06-25T19:59:15.1452634Z   {
2020-06-25T19:59:15.1452978Z     terminal: true,
2020-06-25T19:59:15.1453321Z +   useColors: false
2020-06-25T19:59:15.1453861Z -   useColors: true
2020-06-25T19:59:15.1454225Z   }
2020-06-25T19:59:15.1454841Z     at /home/runner/work/node/node/test/parallel/test-repl-envvars.js:55:12
2020-06-25T19:59:15.1455246Z     at internal/repl.js:33:5

@addaleax
Revert "repl: always check for NODE_REPL_MODE environment variable"
4697c29 
This reverts commit b831b08.

This presumably unbreaks the ASAN github action build.

Example failure:

    2020-06-25T19:59:15.1448178Z === release test-repl-envvars ===
    2020-06-25T19:59:15.1448872Z Path: parallel/test-repl-envvars
    2020-06-25T19:59:15.1449449Z --- stderr ---
    2020-06-25T19:59:15.1449835Z assert.js:103
    2020-06-25T19:59:15.1450194Z   throw new AssertionError(obj);
    2020-06-25T19:59:15.1450524Z   ^
    2020-06-25T19:59:15.1450817Z
    2020-06-25T19:59:15.1451431Z AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
    2020-06-25T19:59:15.1452000Z + actual - expected
    2020-06-25T19:59:15.1452298Z
    2020-06-25T19:59:15.1452634Z   {
    2020-06-25T19:59:15.1452978Z     terminal: true,
    2020-06-25T19:59:15.1453321Z +   useColors: false
    2020-06-25T19:59:15.1453861Z -   useColors: true
    2020-06-25T19:59:15.1454225Z   }
    2020-06-25T19:59:15.1454841Z     at /home/runner/work/node/node/test/parallel/test-repl-envvars.js:55:12
    2020-06-25T19:59:15.1455246Z     at internal/repl.js:33:5
@nodejs-github-bot nodejs-github-bot added the repl Issues and PRs related to the REPL subsystem. label Jun 26, 2020
@addaleax addaleax mentioned this pull request Jun 26, 2020
Closed
4 tasks
@addaleax addaleax added fast-track PRs that do not need to wait for 48 hours to land. revert PRs that revert previously landed PRs. labels Jun 26, 2020
@addaleax
Copy link
Member Author

addaleax commented Jun 26, 2020

Please 👍 this comment to approve fast-tracking to unbreak Github Actions CI

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 26, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32095/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jun 26, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 26, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/32096/

@Trott
Copy link
Member

Trott commented Jun 26, 2020

Landed in 072feec

@Trott Trott closed this Jun 26, 2020
Trott pushed a commit to Trott/io.js that referenced this pull request Jun 26, 2020
@addaleax @Trott
Revert "repl: always check for NODE_REPL_MODE environment variable"
072feec 
This reverts commit b831b08.

This presumably unbreaks the ASAN github action build.

Example failure:

    2020-06-25T19:59:15.1448178Z === release test-repl-envvars ===
    2020-06-25T19:59:15.1448872Z Path: parallel/test-repl-envvars
    2020-06-25T19:59:15.1449449Z --- stderr ---
    2020-06-25T19:59:15.1449835Z assert.js:103
    2020-06-25T19:59:15.1450194Z   throw new AssertionError(obj);
    2020-06-25T19:59:15.1450524Z   ^
    2020-06-25T19:59:15.1450817Z
    2020-06-25T19:59:15.1451431Z AssertionError [ERR_ASSERTION]: Expected values to be strictly deep-equal:
    2020-06-25T19:59:15.1452000Z + actual - expected
    2020-06-25T19:59:15.1452298Z
    2020-06-25T19:59:15.1452634Z   {
    2020-06-25T19:59:15.1452978Z     terminal: true,
    2020-06-25T19:59:15.1453321Z +   useColors: false
    2020-06-25T19:59:15.1453861Z -   useColors: true
    2020-06-25T19:59:15.1454225Z   }
    2020-06-25T19:59:15.1454841Z     at /home/runner/work/node/node/test/parallel/test-repl-envvars.js:55:12
    2020-06-25T19:59:15.1455246Z     at internal/repl.js:33:5

PR-URL: nodejs#34058
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@addaleax addaleax deleted the revert-simplify-repl branch June 26, 2020 11:55
@benjamingr
Copy link
Member

benjamingr commented Jun 26, 2020

cc @BridgeAR

This was referenced Jun 27, 2020
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. repl Issues and PRs related to the REPL subsystem. revert PRs that revert previously landed PRs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@addaleax @nodejs-github-bot @Trott @benjamingr @jasnell