fix drain() function for "Piping to writable streams from async iterators"#34018
Closed
Kosta-Github wants to merge 1 commit intonodejs:masterfrom
Kosta-Github:patch-1
Closed
fix drain() function for "Piping to writable streams from async iterators"#34018Kosta-Github wants to merge 1 commit intonodejs:masterfrom Kosta-Github:patch-1
Kosta-Github wants to merge 1 commit intonodejs:masterfrom
Kosta-Github:patch-1
Conversation
…tors" The sample code for ["Piping to writable streams from async iterators"](https://nodejs.org/docs/latest-v14.x/api/stream.html#stream_piping_to_writable_streams_from_async_iterators) is containing an event listener leak, since it registers 2 event listeners, but don't remove them again. The `drain()` function has been changed to remove all the listeners that have been registered within that function in any case again.
nodejs-github-bot
added
doc
Member
|
Thank you but the example is being removed in #33992 . |
Member
|
Welcome, @Kosta-Github, and thanks for the pull request. Because the example has been removed in another pull request, I'm going to close this. If I'm mistaken about the state of things, please leave a comment or re-open. Thanks again! |
This was referenced May 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The sample code for "Piping to writable streams from async iterators" is containing an event listener leak, since it registers 2 event listeners, but don't remove them again.
The
drain()function has been changed to remove all the listeners that have been registered within that function in any case again.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes