Conversation
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
Welcome, @falguniraina, and thanks for the pull request.
A little pedantic of me, but for whoever lands this: When you edit the commit message, it is more correct (in my opinion, at least) to say that these are style improvements than typos. The text is all correct as it is. This improves the text. Maybe doc: improve text in issues.md or something like that.
Sure Sir!! I will definitely consider such things next time actually i am just a beginner in the open source contribution and trying to understand things!! |
|
|
||
| Short, clipped responses that provide neither additional context nor supporting | ||
| detail are not helpful or professional. To many, such responses are simply | ||
| details are not helpful or professional to many. Such responses are simply |
There was a problem hiding this comment.
| details are not helpful or professional to many. Such responses are simply | |
| details are not helpful or professional. To many, Such responses are simply |
I personally prefer the original sentence break here, but details definitely needs to be pluralized
| annoying and unfriendly. | ||
|
|
||
| Contributors are encouraged to help one another make forward progress as much | ||
| Contributors are encouraged to help one another to make forward progress as much |
There was a problem hiding this comment.
| Contributors are encouraged to help one another to make forward progress as much | |
| Contributors are encouraged to help one another make forward progress as much |
I don't think this change needs to be made. The original sentence is grammatically correct.
|
Landed in c118304 |
PR-URL: #33973 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #33973 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #33973 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #33973 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
9 participants
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes