Skip to content

test: temporarily exclude test on arm#33814

Closed
mhdawson wants to merge 2 commits intonodejs:masterfrom
mhdawson:excltest2
Closed

test: temporarily exclude test on arm#33814
mhdawson wants to merge 2 commits intonodejs:masterfrom
mhdawson:excltest2

Conversation

@mhdawson
Copy link
Member

@mhdawson mhdawson commented Jun 9, 2020 •
edited
Loading

Temporarily excluded until #33796 is resolved.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Jun 9, 2020
@mhdawson
Copy link
Member Author

mhdawson commented Jun 9, 2020

CI run: https://ci.nodejs.org/job/node-test-pull-request/31802/

@mhdawson mhdawson closed this Jun 9, 2020
addaleax
addaleax approved these changes Jun 9, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test is not inherently broken on the platform – it should pass on ARM. Let’s mark it flaky instead of just not running it.

@mhdawson
Copy link
Member Author

mhdawson commented Jun 9, 2020

Would like to ask that this is fast-tracked if it gets CI to green.

@addaleax addaleax reopened this Jun 9, 2020
@mhdawson mhdawson added the fast-track PRs that do not need to wait for 72 hours to land. label Jun 9, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jun 9, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31803/

@mhdawson
Copy link
Member Author

mhdawson commented Jun 9, 2020

Updated CI run: https://ci.nodejs.org/job/node-test-pull-request/31803/

@mhdawson
Copy link
Member Author

mhdawson commented Jun 9, 2020

CI run was green landing.

mhdawson added a commit that referenced this pull request Jun 9, 2020
@mhdawson
test: temporarily exclude test on arm
502f53f 
Refs: #33796

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #33814
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mhdawson
Copy link
Member Author

mhdawson commented Jun 9, 2020

Landed in 502f53f

@mhdawson mhdawson closed this Jun 9, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@mhdawson @codebytere
test: temporarily exclude test on arm
e3a5332 
Refs: #33796

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #33814
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@mhdawson @codebytere
test: temporarily exclude test on arm
4bb0670 
Refs: #33796

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #33814
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
codebytere pushed a commit that referenced this pull request Jul 10, 2020
@mhdawson @codebytere
test: temporarily exclude test on arm
b5113d0 
Refs: #33796

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #33814
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@codebytere codebytere mentioned this pull request Jul 13, 2020
Merged
codebytere pushed a commit that referenced this pull request Jul 14, 2020
@mhdawson @codebytere
test: temporarily exclude test on arm
ce0ab70 
Refs: #33796

Signed-off-by: Michael Dawson <[email protected]>

PR-URL: #33814
Reviewed-By: Anna Henningsen <[email protected]>
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
@mhdawson mhdawson deleted the excltest2 branch September 14, 2020 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

fast-track PRs that do not need to wait for 72 hours to land. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@mhdawson @nodejs-github-bot @addaleax @lpinca @richardlau