Conversation
|
Also I did not fix the tests at the top that check |
lib/internal/event_target.js
Outdated
There was a problem hiding this comment.
Adding a comment in here that we currently do not use the CAPTURING_PHASE and BUBBLING_PHASE but that they need to be preserved anyway because of the spec would be good.
8ae28ff to
2935f72
Compare
Co-authored-by: James M Snell <jasnell@gmail.com>
|
Adding a fixup commit resolving the rebase conflict. |
|
@benjamingr ... can I ask to you squash the commits here? |
|
Sure though I have a computer without built node so I am doing everything "blind" until early next week. |
|
@jasnell I see there is a merge commit present - I assume that's not intentional? Can I pluck it out and squash the other two? |
|
Actually, don't worry about squashing or fixing up. I'm combining all these PRs into a single PR to make landing them easier |
|
@jasnell to be explicit, you have my explicit consent (and blessing) to do as you wish with the code here and in the other PRs (and in follow up event-target PRs when I get back to my workstation next week). |
|
Closing in favor of #34015 (which combines this and other |
Expose Event statics (Event.NONE etc). See Event phase constants.
I think these are required on the event interface (as constants).
They are as-enumerable as they are in browsers though I did not add a specific test for enumerability (I can if people feel strongly about it)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes