events: cancelBubble is a property#33613
Closed
benjamingr wants to merge 2 commits intonodejs:masterfrom
Closed
Conversation
benjamingr
added
the
events
benjamingr
changed the title
Member
|
I'd be in favor of implementing these properties by following the spec: https://dom.spec.whatwg.org/#stop-propagation-flag |
Member
|
Yeah, even tho we're not making use of this at all, we should at least preserve the value of the flag. |
Member
Author
|
@targos ok, I'll update this to reflect the flag. |
benjamingr
force-pushed
the
event-target-cancel-bubble
branch
from
92aaaf3 to
7d25bf5
Compare
Member
Author
|
@targos I pushed a property and added some tests to check the behavior. Still definitely not perfect, I would eventually like to run better tests on this (following the guide), I am starting by doing a shallow run now to get familiarized with the code - and so there are a bunch of small PRs rather than a large-ish one for compatibility. |
jasnell
approved these changes
May 28, 2020
targos
approved these changes
May 28, 2020
BridgeAR
approved these changes
May 28, 2020
Collaborator
BridgeAR
added
the
author ready
Member
|
@benjamingr ... thank you for going through these, btw... it would have been at least a week before I would have been able to get back to it. |
juanarbol
approved these changes
May 28, 2020
4 tasks
benjamingr
force-pushed
the
event-target-cancel-bubble
branch
from
1a827f4 to
a1064d5
Compare
benjamingr
added a commit
that referenced
this pull request
May 31, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Member
Author
|
|
2 tasks
BridgeAR
force-pushed
the
event-target-cancel-bubble
branch
from
d65c8d1 to
b1ba21f
Compare
Collaborator
Collaborator
Collaborator
Member
|
@benjamingr ... this needs a rebase |
Member
Author
|
rebased |
benjamingr
force-pushed
the
event-target-cancel-bubble
branch
from
b1ba21f to
9f28785
Compare
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test.
benjamingr
force-pushed
the
event-target-cancel-bubble
branch
from
9f28785 to
412d82d
Compare
This was referenced Jun 4, 2020
Collaborator
lundibundi
approved these changes
Jun 4, 2020
jasnell
pushed a commit
that referenced
this pull request
Jun 4, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Member
|
Landed in 3128915 |
codebytere
pushed a commit
that referenced
this pull request
Jun 18, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
benjamingr
added a commit
to benjamingr/io.js
that referenced
this pull request
Jun 21, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: nodejs#33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Jun 22, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: nodejs#33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Jun 24, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #34015 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #34015 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test. PR-URL: #33613 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> PR-URL: #34015 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Event#cancelBubble is property (and not a function). Change Event#cancelBubble to a property and add a test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes