repl: improve static import error message in repl#33588
Closed
MylesBorins wants to merge 1 commit intonodejs:masterfrom
Closed
repl: improve static import error message in repl#33588MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins wants to merge 1 commit intonodejs:masterfrom
Conversation
Collaborator
MylesBorins
added
the
esm
BridgeAR
reviewed
May 27, 2020
BridgeAR
force-pushed
the
master
branch
2 times, most recently
from
8ae28ff to
2935f72
Compare
MylesBorins
force-pushed
the
better-repl-error
branch
from
94e46ab to
576de38
Compare
Contributor
Author
|
I've updated PTAL @BridgeAR I don't think we need to check the length on this. If someone is explicitly messing with the stack size I'm pretty happy that this feature might fail for them. Thoughts? |
MylesBorins
commented
Jul 20, 2020
lib/repl.js
Outdated
Contributor
Author
There was a problem hiding this comment.
we could alternative find which item in the array starts with SyntaxError rather than by default using the 5th item
Member
There was a problem hiding this comment.
That sounds better to me. There is in fact similar code to determine that line below. It'll only be triggered in case there's no uncaughtException listener though.
Contributor
Author
There was a problem hiding this comment.
Updated to use regex PTAL
Member
|
Is it not possible to just fix static import? That would be most user friendly and I would rather have that. I guess it might be tricky to implement it though? |
Contributor
Author
|
@BridgeAR AFAIK there is no way to implement static import in the REPL. I could be wrong, but in lieu of a solution to that this seems like the next best thing. |
jasnell
approved these changes
Jul 21, 2020
Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: nodejs#33576
MylesBorins
force-pushed
the
better-repl-error
branch
from
d83bb30 to
4a7fe9a
Compare
Collaborator
guybedford
approved these changes
Jul 24, 2020
MylesBorins
added
the
author ready
Contributor
Author
|
hey @BridgeAR are you ok with this landing? |
Contributor
Author
|
Pinging @BridgeAR one more time. I'll land in 48 hours if I don't hear anything. |
BridgeAR
approved these changes
Aug 5, 2020
MylesBorins
added a commit
that referenced
this pull request
Aug 5, 2020
Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: #33576 PR-URL: #33588 Fixes: #33576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Contributor
Author
|
Landed in 861a54c |
Trott
reviewed
Aug 6, 2020
| expect: '42' | ||
| }, | ||
| { | ||
| send: 'import comeOn from \'fhqwhgads\'', |
Member
There was a problem hiding this comment.
Suggested change
| send: 'import comeOn from \'fhqwhgads\'', | |
| send: 'import everybody from \'the limit\'', |
Member
There was a problem hiding this comment.
On second thought...
Suggested change
| send: 'import comeOn from \'fhqwhgads\'', | |
| send: 'import theLimit from \'everybody\'', |
Member
There was a problem hiding this comment.
Long descriptive names are preferable.
Suggested change
| send: 'import comeOn from \'fhqwhgads\'', | |
| send: 'import comeOn from \'fhqwhgadshgnsdhjsdbkhsdabkfabkveybvf\'', |
Contributor
Author
There was a problem hiding this comment.
LOLOLOL
guess this will need to come in a followup
codebytere
pushed a commit
that referenced
this pull request
Aug 6, 2020
Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: #33576 PR-URL: #33588 Fixes: #33576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
codebytere
pushed a commit
that referenced
this pull request
Aug 11, 2020
Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: #33576 PR-URL: #33588 Fixes: #33576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins
added a commit
that referenced
this pull request
Nov 3, 2020
Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: #33576 PR-URL: #33588 Fixes: #33576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins
added a commit
that referenced
this pull request
Nov 16, 2020
Currently the error is rather ambiguous and does not inform folks that static import is not supported in the repl. This overrides the default error message with one that is more informative. Closes: #33576 PR-URL: #33588 Fixes: #33576 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently the error is rather ambiguous and does not inform folks that
static import is not supported in the repl. This overrides the default
error message with one that is more informative.
Closes: #33576