Skip to content

tools: fix master branch build for Windows on Arm#33511

Closed
richard-townsend-arm wants to merge 2 commits intonodejs:masterfrom
richard-townsend-arm:woa-compile-fix
Closed

tools: fix master branch build for Windows on Arm#33511
richard-townsend-arm wants to merge 2 commits intonodejs:masterfrom
richard-townsend-arm:woa-compile-fix

Conversation

@richard-townsend-arm
Copy link
Contributor

@richard-townsend-arm richard-townsend-arm commented May 22, 2020

Follow up to #32867, the new version of V8 (and new version of zlib) require a few definition fixups. After this, the master branch should build successfully for Windows on Arm.

CC @joaocgreis

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label May 22, 2020
@richardlau richardlau added arm Issues and PRs related to the ARM platform. build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels May 22, 2020
richardlau
richardlau reviewed May 22, 2020
View reviewed changes
@richard-townsend-arm
tools: fix GetCurrentThreadStackLimits error on Windows on Arm
1336924 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1
@richard-townsend-arm
fix: zlib build error on Windows on Arm
7725262 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

Change-Id: I011134f5680719e8fc246b8c660ececf0c596fd8
@richard-townsend-arm
Copy link
Contributor Author

richard-townsend-arm commented May 29, 2020

Cool, so the possibly Win 7 breaking change is now gated behind a flag. CI flakes look spurious (they all fail on platforms that are unchanged). Ready for review. Once the change is adopted, I'll build and test the master branch daily and try to fix any failures as they arise.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 29, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31632/

@richard-townsend-arm
Copy link
Contributor Author

richard-townsend-arm commented May 29, 2020

Cool, thanks for that - I don’t have permission to merge though.

BridgeAR
BridgeAR approved these changes May 30, 2020
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 30, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 30, 2020 •
edited by BridgeAR
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/31647/ 💚

@BridgeAR
Copy link
Member

BridgeAR commented May 30, 2020

Landed in 99abaf9...ce025d9

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 30, 2020
@richard-townsend-arm @BridgeAR
build: fix GetCurrentThreadStackLimits error on Windows on Arm
54e5c36 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request May 30, 2020
@richard-townsend-arm @BridgeAR
build: zlib build error on Windows on Arm
ce025d9 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@BridgeAR BridgeAR closed this May 30, 2020
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@richard-townsend-arm @codebytere
build: fix GetCurrentThreadStackLimits error on Windows on Arm
fc03224 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: #33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@richard-townsend-arm @codebytere
build: zlib build error on Windows on Arm
3ac05b7 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: #33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere codebytere mentioned this pull request Jun 28, 2020
Merged
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@richard-townsend-arm @codebytere
build: fix GetCurrentThreadStackLimits error on Windows on Arm
b90565f 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: #33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@richard-townsend-arm @codebytere
build: zlib build error on Windows on Arm
27f8378 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: #33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@codebytere
Copy link
Member

codebytere commented Jul 8, 2020

@richard-townsend-arm this conflicts in a handful of places - could you please manually backport it to v12.x?

@dennisameling dennisameling mentioned this pull request Aug 8, 2020
Closed
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
ee8c92a 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
9904668 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
adcebfd 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 14, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
46acca1 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
d33bdd1 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
b2ede04 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
6ec9ac8 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
5a2f166 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
23cd789 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
0fee8fb 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
3e130a8 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
da216f5 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
c1bea99 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
771de93 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
df89339 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
638fcfd 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
61dcb3f 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 15, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
47180d0 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
25a2eb0 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
6e3da34 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
ce5e324 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
35d9741 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
1fc3801 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
d9ba068 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@richard-townsend-arm @Trott
build: fix GetCurrentThreadStackLimits error on Windows on Arm
8239315 
GetCurrentThreadStackLimits is a fairly new API, so it requires a
_WIN32_WINNT value of at least 0x0602 to compile successfully.

Change-Id: Ib3bc24513453aa37bee68f4a6999cefc26947cb1

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 16, 2021
@richard-townsend-arm @Trott
build: zlib build error on Windows on Arm
5a42642 
Zlib's SIMD optimizations are not supported in MSVC, so fall back to the
C versions for now.

PR-URL: nodejs#33511
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Shelley Vohr <codebytere@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@codebytere codebytere codebytere approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees

No one assigned

Labels

arm Issues and PRs related to the ARM platform. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@richard-townsend-arm @nodejs-github-bot @BridgeAR @codebytere @jasnell @richardlau