[v14.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write#33490
Closed
rexagod wants to merge 3 commits intonodejs:v14.x-stagingfrom
Closed
[v14.x backport] http: don't throw on Uint8Arrays for http.ServerResponse#write#33490rexagod wants to merge 3 commits intonodejs:v14.x-stagingfrom
Uint8Arrays for http.ServerResponse#write#33490rexagod wants to merge 3 commits intonodejs:v14.x-stagingfrom
Conversation
Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: nodejs#33490 PR-URL: nodejs#33155 Fixes: nodejs#33379 Refs: nodejs#29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
rexagod
changed the title
Uint8Arrays for http.ServerResponse#writeUint8Arrays for http.ServerResponse#write
rexagod
changed the title
Uint8Arrays for http.ServerResponse#writeUint8Arrays for http.ServerResponse#write
rexagod
force-pushed
the
backport-33155-to-v14.x
branch
from
e45a84b to
4732f15
Compare
Member
Author
|
|
Member
|
@nodejs/http @ronag PTAL |
ronag
reviewed
May 30, 2020
ronag
reviewed
May 30, 2020
ronag
requested changes
May 30, 2020
Member
ronag
left a comment
ronag
left a comment
There was a problem hiding this comment.
Contains unrelated semver major changes. Please remove those.
Member
Author
|
Made similar changes for v12.x backport as well. |
ronag
approved these changes
May 31, 2020
Collaborator
ronag
added
the
author ready
Collaborator
BethGriggs
reviewed
Jun 9, 2020
codebytere
approved these changes
Jun 27, 2020
Member
|
Landed in feb6e1f |
codebytere
pushed a commit
that referenced
this pull request
Jun 27, 2020
Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: #33490 PR-URL: #33155 Fixes: #33379 Refs: #29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jun 28, 2020
codebytere
pushed a commit
that referenced
this pull request
Jun 30, 2020
Don't throw errors on Uint8Arrays and added test for all valid types. Backport-PR-URL: #33490 PR-URL: #33155 Fixes: #33379 Refs: #29829 Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Jul 1, 2020
This was referenced Jul 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't throw errors on Uint8Arrays and added test for all
valid types.
PR-URL: #33155
Fixes: #33379
Refs: #29829
Reviewed-By: Robert Nagy ronagy@icloud.com
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Zeyu Yang himself65@outlook.com
Reviewed-By: James M Snell jasnell@gmail.com
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes