src: add default: case to silence compiler warning#33451
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
src: add default: case to silence compiler warning#33451addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
This fails compilation on at least one platform because there is no `default:` case, despite all currently possible enum values being listed. Fix that by adding a default message that won’t be used unless V8 introduces new enum values. Refs: nodejs@c7eeef5#commitcomment-39228519
nodejs-github-bot
added
the
c++
addaleax
referenced
this pull request
May 18, 2020
Adds a flag that helps with debugging deadlocks due to incorrectly implemented `Atomics.wait()` calls. PR-URL: #33292 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
cjihrig
approved these changes
May 18, 2020
BridgeAR
approved these changes
May 18, 2020
Member
|
Collaborators please 👍 to fast track this |
addaleax
added
author ready
Collaborator
danbev
approved these changes
May 18, 2020
richardlau
approved these changes
May 18, 2020
richardlau
pushed a commit
that referenced
this pull request
May 18, 2020
This fails compilation on at least one platform because there is no `default:` case, despite all currently possible enum values being listed. Fix that by adding a default message that won’t be used unless V8 introduces new enum values. Refs: c7eeef5#commitcomment-39228519 PR-URL: #33451 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Member
|
Landed in 0e5b975. |
codebytere
pushed a commit
that referenced
this pull request
May 19, 2020
This fails compilation on at least one platform because there is no `default:` case, despite all currently possible enum values being listed. Fix that by adding a default message that won’t be used unless V8 introduces new enum values. Refs: c7eeef5#commitcomment-39228519 PR-URL: #33451 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Merged
This was referenced Jan 25, 2022
This was referenced Sep 27, 2022
This was referenced Sep 28, 2022
This was referenced Dec 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fails compilation on at least one platform because there is no
default:case, despite all currently possible enum values beinglisted.
Fix that by adding a default message that won’t be used unless V8
introduces new enum values.
Refs: c7eeef5#commitcomment-39228519
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes