doc: fix esm extension example with type module#33409
doc: fix esm extension example with type module#33409guybedford wants to merge 2 commits intomasterfrom
Conversation
|
If our docs blindly tell you to set a configuration parameter every time you set up a project, we should make that parameter the default. |
|
@devsnek yes making it the default in npm init and other tooling is a high priority! We need to chase up those conversations. The reason we can't blanket make it the default is because the defaults are for third-party package support for CommonJS. There's simply no way to change the default as a blanket rule without timestamping packages or having support directly in npm tooling / the registry itself. Please do try to work on your tone... the project is only as good as we treat eachother. |
|
Ok to put it another way, if we can't make it the default (as in how node behaves with no package.json present) then it shouldn't be the heading example. |
|
@devsnek if it matters to you that much then sure, let's merge your original PR. But the fact that your terrible tone is winning this argument makes me pretty sad. |
|
@guybedford apologies, i am not intending any animosity |
As an alternative to #33408, fixing up the docs issue with the
"type": "module"instructions, while still noting.mjs.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes