src: refactor Reallocate since it introduced in upstream v8#33402
Closed
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Closed
src: refactor Reallocate since it introduced in upstream v8#33402gengjiawen wants to merge 1 commit intonodejs:masterfrom
gengjiawen wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
Member
Author
|
Fast track ? |
Closed
Collaborator
himself65
approved these changes
May 14, 2020
richardlau
approved these changes
May 14, 2020
benjamingr
approved these changes
May 14, 2020
gengjiawen
added
the
fast-track
Collaborator
jasnell
approved these changes
May 14, 2020
Collaborator
cjihrig
approved these changes
May 14, 2020
Collaborator
gengjiawen
added a commit
that referenced
this pull request
May 14, 2020
PR-URL: #33402 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
Author
|
Landed in 4ad2692 |
codebytere
pushed a commit
that referenced
this pull request
May 16, 2020
PR-URL: #33402 Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #33401.
cherrpick from V8 canary branch