fs: readdir fails when libuv returns UV_DIRENT_UNKNOWN and the first arg is Buffer

[shackijj]

Refs: #33348

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• commit message follows commit guidelines

[shackijj]

Created this PR as to check if the test fails on Ubuntu.

[BridgeAR]

@shackijj there is a single failure on Linux:

=== release test-fs-utils-get-dirents ===
Path: parallel/test-fs-utils-get-dirents
--- stderr ---
internal/validators.js:121
    throw new ERR_INVALID_ARG_TYPE(name, 'string', value);
    ^

TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received an instance of Buffer
    at validateString (internal/validators.js:121:11)
    at Object.join (path.js:1039:7)
    at getDirents (internal/fs/utils.js:188:39)
    at Object.<anonymous> (/home/runner/work/node/node/test/parallel/test-fs-utils-get-dirents.js:33:5)
    at Module._compile (internal/modules/cjs/loader.js:1200:30)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:1220:10)
    at Module.load (internal/modules/cjs/loader.js:1049:32)
    at Function.Module._load (internal/modules/cjs/loader.js:937:14)
    at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
    at internal/main/run_main_module.js:17:47 {
  code: 'ERR_INVALID_ARG_TYPE'
}

[shackijj]

@BridgeAR thanks. I haven't implemented a fix for the bug yet. Tests fail and it's expected for now.

I'm trying to figure out how we should handle cases when we need to join a string and a Buffer, and two Buffers. Do you have any thoughs on that?

[shackijj]

@addaleax could you please take a look at this PR?

[shackijj]

Could anyone relaunch the CI pipline please?

[shackijj]

Could anyone relaunch the CI pipline please?

relaunched through commit

[shackijj]

@addaleax I made the changes that you suggested. Could you please review the code again? Should I do something else?

[addaleax]

Yes, thanks for the ping :)

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32049/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32062/ CI job hung on one of the rasp pis... trying again

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32064/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/32077/

[jasnell]

Landed in 82f13fa