Skip to content

module: lazy load 'getOptionValue' in initializeLoader#33212

Closed
himself65 wants to merge 1 commit intonodejs:masterfrom
himself65:20200502-module-getOptionValue
Closed

module: lazy load 'getOptionValue' in initializeLoader#33212
himself65 wants to merge 1 commit intonodejs:masterfrom
himself65:20200502-module-getOptionValue

Conversation

@himself65
Copy link
Member

@himself65 himself65 commented May 2, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label May 2, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 2, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31142/

@juanarbol juanarbol requested a review from guybedford May 4, 2020 02:59
@HarshithaKP
Copy link
Member

HarshithaKP commented May 4, 2020

@himself65, can you please explain why this change is made ?

addaleax
addaleax approved these changes May 4, 2020
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If nothing else, this enables loading this module during early bootstrapping

@himself65
Copy link
Member Author

himself65 commented May 4, 2020

@himself65, can you please explain why this change is made ?

addaleax has said what I wanna say

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31162/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 4, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31163/

@himself65 himself65 self-assigned this May 6, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31185/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31187/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31188/

@richardlau
Copy link
Member

richardlau commented May 6, 2020

If nothing else, this enables loading this module during early bootstrapping

If whoever lands this could add some words to the commit description paraphrasing the above (the "why this is being done") it would be very helpful for anyone browsing through commit history later on.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31189/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 6, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31190/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 7, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31198/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 7, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31200/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 7, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31201/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 7, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31202/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 7, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/31203/

addaleax pushed a commit that referenced this pull request May 7, 2020
@himself65 @addaleax
module: lazy load 'getOptionValue' in initializeLoader
f153081 
This enables loading this module during early bootstrapping.

PR-URL: #33212
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@addaleax
Copy link
Member

addaleax commented May 7, 2020

Landed in f153081

@addaleax addaleax closed this May 7, 2020
codebytere pushed a commit that referenced this pull request May 11, 2020
@himself65 @codebytere
module: lazy load 'getOptionValue' in initializeLoader
27b814c 
This enables loading this module during early bootstrapping.

PR-URL: #33212
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@codebytere codebytere mentioned this pull request May 18, 2020
Merged
@codebytere
Copy link
Member

codebytere commented Jun 7, 2020

@himself65 this change can't currently apply to v12.x since a6b030d was landed with alterations on the v12.x branch: 02c4d27.

I'm going to tag it for now with dont-land but if you feel like trying to make it work you're welcome to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jasnell jasnell jasnell approved these changes

@guybedford guybedford guybedford approved these changes

@addaleax addaleax addaleax approved these changes

@richardlau richardlau richardlau approved these changes

Assignees

@himself65 himself65

Labels

process Issues and PRs related to the process subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@himself65 @nodejs-github-bot @HarshithaKP @richardlau @addaleax @codebytere @jasnell @guybedford