test: add tests for options.fs in fs streams#33185
Closed
julianduque wants to merge 1 commit intonodejs:masterfrom
Closed
test: add tests for options.fs in fs streams#33185julianduque wants to merge 1 commit intonodejs:masterfrom
julianduque wants to merge 1 commit intonodejs:masterfrom
Conversation
edsadr
reviewed
May 1, 2020
Member
edsadr
left a comment
edsadr
left a comment
There was a problem hiding this comment.
Just a suggestion but looks nice 🙂
julianduque
force-pushed
the
julianduque/test-fs-streams-fs-options
branch
from
6e16e76 to
e1e860a
Compare
julianduque
force-pushed
the
julianduque/test-fs-streams-fs-options
branch
from
e1e860a to
c671654
Compare
juanarbol
requested changes
May 1, 2020
Member
juanarbol
left a comment
juanarbol
left a comment
There was a problem hiding this comment.
The only exception thrown is here https://github.com/nodejs/node/blob/master/lib/internal/fs/streams.js#L83, the rest of them are not being touched.
julianduque
force-pushed
the
julianduque/test-fs-streams-fs-options
branch
from
c671654 to
258a8ca
Compare
Contributor
Author
|
@juanarbol addressed your comments, all branches are being tested now. |
juanarbol
reviewed
May 1, 2020
juanarbol
requested changes
May 1, 2020
julianduque
force-pushed
the
julianduque/test-fs-streams-fs-options
branch
from
258a8ca to
41415f4
Compare
juanarbol
added
the
author ready
Collaborator
juanarbol
pushed a commit
that referenced
this pull request
May 4, 2020
PR-URL: #33185 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Member
|
Landed in 39ff647 🎉 |
codebytere
pushed a commit
that referenced
this pull request
May 7, 2020
PR-URL: #33185 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Jun 7, 2020
PR-URL: #33185 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This add tests for the new
options.fsoverride methods in thefsStream operationsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes