[v12.x] tools: fix mkcodecache when run with ASAN#33128
Closed
addaleax wants to merge 2 commits intonodejs:v12.x-stagingfrom
Closed
[v12.x] tools: fix mkcodecache when run with ASAN#33128addaleax wants to merge 2 commits intonodejs:v12.x-stagingfrom
addaleax wants to merge 2 commits intonodejs:v12.x-stagingfrom
Conversation
Fixes: nodejs#32835 PR-URL: nodejs#32850 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
nodejs-github-bot
added
tools
Collaborator
targos
approved these changes
May 2, 2020
targos
pushed a commit
that referenced
this pull request
May 2, 2020
Fixes: #32835 PR-URL: #32850 Backport-PR-URL: #33128 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Member
|
Landed in d072f08. Thanks |
targos
pushed a commit
that referenced
this pull request
May 13, 2020
Fixes: #32835 PR-URL: #32850 Backport-PR-URL: #33128 Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #32835
PR-URL: #32850
(The first commit is a clean cherry-pick, the second/fixup commit fixes this up for v12.x)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes