Closed
Conversation
cjihrig
approved these changes
Apr 21, 2020
lpinca
approved these changes
Apr 21, 2020
jasnell
approved these changes
Apr 21, 2020
Member
jasnell
left a comment
jasnell
left a comment
There was a problem hiding this comment.
A corresponding update should be made on the blog post: https://github.com/nodejs/nodejs.org/blob/master/locale/en/blog/release/v14.0.0.md
Member
Author
|
What are the rules on merging doc-only changes? |
Contributor
|
BridgeAR
approved these changes
Apr 21, 2020
Member
|
In general, the rules are the same as any commit unless fast-track is ok'd by at least two collaborators. |
Member
Author
|
👍 to fast track? |
Member
i.e. doc-only changes do not require Jenkins CI to be run but do require the GitHub Actions to pass. |
gengjiawen
approved these changes
Apr 22, 2020
devsnek
added a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32979 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
devsnek
force-pushed
the
devsnek-patch-1
branch
from
dc6b502 to
d08bd41
Compare
Member
Author
|
landed in d08bd41 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32979 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes