stream: don't emit finish after close#32933
Closed
ronag wants to merge 6 commits intonodejs:masterfrom
Closed
Conversation
ronag
force-pushed
the
stream-finish-after-close
branch
3 times, most recently
from
8bf2442 to
ec3e537
Compare
Member
Author
|
@nodejs/streams |
lpinca
approved these changes
Apr 22, 2020
mcollina
reviewed
Apr 22, 2020
Member
mcollina
left a comment
mcollina
left a comment
There was a problem hiding this comment.
Given that the PR mention 'close', it would be good to add a few mustCall()/mustNotCall() for that as well.
ronag
force-pushed
the
stream-finish-after-close
branch
from
f9154ec to
604191b
Compare
Member
Author
|
added some missing mustCalls |
Writable stream could emit 'finish' after 'close'.
ronag
force-pushed
the
stream-finish-after-close
branch
from
604191b to
7da4656
Compare
Collaborator
Collaborator
mcollina
reviewed
Apr 25, 2020
ronag
force-pushed
the
stream-finish-after-close
branch
from
065eb38 to
706e189
Compare
Collaborator
ronag
added a commit
that referenced
this pull request
Apr 27, 2020
Writable stream could emit 'finish' after 'close'. PR-URL: #32933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
Author
|
Landed in f5c11a1 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
Writable stream could emit 'finish' after 'close'. PR-URL: #32933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Apr 28, 2020
Writable stream could emit 'finish' after 'close'. PR-URL: #32933 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
Author
4 tasks
Member
4 tasks
Member
Author
|
Yes. I'm a little overloaded at the moment though. If you need help ping me again in a. week :). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Writable stream could emit 'finish' after 'close'.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes