src: elevate already elevated v8::HeapSnapshot namespace#32854
Closed
juanarbol wants to merge 1 commit intonodejs:masterfrom
Closed
src: elevate already elevated v8::HeapSnapshot namespace#32854juanarbol wants to merge 1 commit intonodejs:masterfrom
juanarbol wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
c++
addaleax
approved these changes
Apr 14, 2020
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
By the way, Node.js commit messages are the only things that refers to this as “elevating namespaces”. I assume somebody started using it at some point and other people just followed that convention. I don’t really have a good alternative suggestion, but if somebody does, feel free to mention that. :)
cjihrig
approved these changes
Apr 14, 2020
addaleax
added
the
author ready
Collaborator
Collaborator
gireeshpunathil
approved these changes
Apr 15, 2020
Member
|
@addaleax - I suspect / confess that it was me who came with this wording! (unless someone want to claim this :) ) . Alternative is:
|
Member
Author
|
@gireeshpunathil |
jasnell
approved these changes
Apr 15, 2020
BridgeAR
approved these changes
Apr 17, 2020
juanarbol
added a commit
that referenced
this pull request
Apr 18, 2020
PR-URL: #32854 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Member
Author
|
Landed in 392bba4 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32854 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32854 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32854 Reviewed-By: Anna Henningsen <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Gireesh Punathil <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Ruben Bridgewater <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes