Skip to content

doc: add link to code ide configs#32767

Closed
ronag wants to merge 1 commit intonodejs:masterfrom
nxtedition:ide-settings
Closed

doc: add link to code ide configs#32767
ronag wants to merge 1 commit intonodejs:masterfrom
nxtedition:ide-settings

Conversation

@ronag
Copy link
Member

@ronag ronag commented Apr 10, 2020

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Apr 10, 2020
richardlau
richardlau reviewed Apr 10, 2020
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve no firm opinion on this since I don’t use an IDE. There was some discussion in #24012 as to whether the link went in the building or contributing document.

@ronag
Copy link
Member Author

ronag commented Apr 10, 2020 •
edited
Loading

There was some discussion in #24012 as to whether the link went in the building or contributing document.

Previously it was specific to debug/running with nodejs/node-code-ide-configs#6 I think this is also an appropriate place.

@himself65
Copy link
Member

himself65 commented Apr 10, 2020 •
edited
Loading

I notice that we already have the description in doc.
but I think it's less noticeable for readers (it's under Running Tests block), IDE config could be used for all this project. so LGTM

@ronag ronag added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 10, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 10, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/30629/

@himself65 himself65 self-assigned this Apr 13, 2020
@himself65 himself65 closed this Apr 13, 2020
@himself65 himself65 reopened this Apr 13, 2020
@himself65
Copy link
Member

himself65 commented Apr 13, 2020

oh, no. I push this PR by mistake with no reviewers message. force pushed

himself65 pushed a commit that referenced this pull request Apr 13, 2020
@ronag @himself65
doc: add link to code ide configs
cf888ac 
Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@himself65
Copy link
Member

himself65 commented Apr 13, 2020

Landed in cf888ac

@himself65 himself65 closed this Apr 13, 2020
targos pushed a commit that referenced this pull request Apr 13, 2020
@ronag @targos
doc: add link to code ide configs
0a8e075 
Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Apr 13, 2020
Merged
BethGriggs pushed a commit that referenced this pull request Apr 14, 2020
@ronag @BethGriggs
doc: add link to code ide configs
0538dd1 
Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos pushed a commit that referenced this pull request Apr 22, 2020
@ronag @targos
doc: add link to code ide configs
af392a1 
Refs: #32764
PR-URL: #32767
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau left review comments

@himself65 himself65 himself65 approved these changes

@trivikr trivikr trivikr approved these changes

Assignees

@himself65 himself65

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ronag @himself65 @nodejs-github-bot @richardlau @trivikr