test: cover node entry type in perf_hooks#32751
Closed
julianduque wants to merge 1 commit intonodejs:masterfrom
Closed
test: cover node entry type in perf_hooks#32751julianduque wants to merge 1 commit intonodejs:masterfrom
julianduque wants to merge 1 commit intonodejs:masterfrom
Conversation
edsadr
approved these changes
Apr 10, 2020
himself65
approved these changes
Apr 10, 2020
Collaborator
julianduque
force-pushed
the
julianduque/test-cover-node-perf-entry-type
branch
from
811883f to
d45b50c
Compare
lpinca
approved these changes
Apr 10, 2020
addaleax
added
the
author ready
Collaborator
Member
|
Landed in 74ec011 |
puzpuzpuz
pushed a commit
to puzpuzpuz/node
that referenced
this pull request
Apr 14, 2020
PR-URL: nodejs#32751 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2020
PR-URL: #32751 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
PR-URL: nodejs#32751 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32751 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32751 Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
nodeas an entry type on the observe test to increase coverage on that moduleChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passes