build: move doc versions JSON file out of out/doc#32728
Merged
richardlau merged 1 commit intonodejs:masterfrom Apr 11, 2020
Merged
build: move doc versions JSON file out of out/doc#32728richardlau merged 1 commit intonodejs:masterfrom
richardlau merged 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
the
build
Collaborator
codebytere
approved these changes
Apr 8, 2020
Collaborator
Trott
approved these changes
Apr 9, 2020
richardlau
added
the
author ready
lpinca
approved these changes
Apr 9, 2020
gengjiawen
approved these changes
Apr 10, 2020
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: nodejs#32728 Fixes: nodejs/build#2276 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Member
Author
|
Landed in ce21749. |
targos
pushed a commit
that referenced
this pull request
Apr 13, 2020
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32728 Fixes: nodejs/build#2276 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 14, 2020
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32728 Fixes: nodejs/build#2276 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
richardlau
added a commit
that referenced
this pull request
Apr 17, 2020
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32728 Fixes: nodejs/build#2276 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32728 Fixes: nodejs/build#2276 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jun 2, 2020
Move the generated previous doc versions JSON file out of `out/doc` to prevent it being included in the distributed packages. Signed-off-by: Richard Lau <riclau@uk.ibm.com> PR-URL: #32728 Fixes: nodejs/build#2276 Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the generated previous doc versions JSON file out of
out/doctoprevent it being included in the distributed packages.
Fixes: nodejs/build#2276
cc @codebytere
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes