lib: removes unnecessary else statement#32662
Closed
JesuHrz wants to merge 1 commit intonodejs:masterfrom
Closed
Conversation
nodejs-github-bot
added
the
fs
lpinca
approved these changes
Apr 5, 2020
rickyes
approved these changes
Apr 5, 2020
2 tasks
jasnell
reviewed
Apr 7, 2020
lib/internal/fs/promises.js
Outdated
Member
There was a problem hiding this comment.
This can be further simplified to:
return options.encoding ? result.toString(options.encoding) : result;
Contributor
Author
There was a problem hiding this comment.
Thanks @jasnell for the feedback, I will make this change right now.
JesuHrz
force-pushed
the
jesuhrz/removes-unnecesary-else-block
branch
from
1684504 to
36b9d10
Compare
BridgeAR
approved these changes
Apr 17, 2020
jasnell
approved these changes
Apr 18, 2020
Collaborator
Collaborator
Member
|
Landed in a6a15fe. |
lpinca
pushed a commit
that referenced
this pull request
Apr 19, 2020
PR-URL: #32662 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 27, 2020
PR-URL: #32662 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
BridgeAR
pushed a commit
that referenced
this pull request
Apr 28, 2020
PR-URL: #32662 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Apr 30, 2020
PR-URL: #32662 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
lpinca
added a commit
to lpinca/node
that referenced
this pull request
May 15, 2020
4 tasks
lpinca
added a commit
to lpinca/node
that referenced
this pull request
Jul 9, 2020
Refs: nodejs#32644 Refs: nodejs#32662 PR-URL: nodejs#32667 Backport-PR-URL: nodejs#34275 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Jul 13, 2020
codebytere
pushed a commit
that referenced
this pull request
Jul 14, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
elsestatement inside the readFileHandle function since exists areturnin theifstatement which makes that theelsestatement unnecessarymake -j4 test(UNIX), orvcbuild test(Windows) passes