test: copy addons .gitignore to test/abort/#32624
Closed
addaleax wants to merge 1 commit intonodejs:masterfrom
Closed
test: copy addons .gitignore to test/abort/#32624addaleax wants to merge 1 commit intonodejs:masterfrom
addaleax wants to merge 1 commit intonodejs:masterfrom
Conversation
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: nodejs#31740
Member
Author
|
Please 👍 this comment to approve fast-tracking |
richardlau
approved these changes
Apr 2, 2020
Member
|
Fwiw I don’t think that new test will be run on the CI because the test configuration won’t find it. But that’s one for a follow up PR. |
Member
Yeah the new test wasn't being run and AFAICT it's broken: #31740 (comment) |
addaleax
removed
the
fast-track
richardlau
added
the
fast-track
Member
Believe I've fixed up the test: #32626 |
jasnell
approved these changes
Apr 3, 2020
addaleax
added
author ready
Member
Author
|
Landed in cf659c8 |
addaleax
added a commit
that referenced
this pull request
Apr 5, 2020
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: #31740 PR-URL: #32624 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: #31740 PR-URL: #32624 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: #31740 PR-URL: #32624 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
`cp test/addons/.gitignore test/abort/.gitignore`, because the new addon test in there leaves a build/ folder lying around and somebody is bound to use `git add .` earlier or later. Refs: #31740 PR-URL: #32624 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cp test/addons/.gitignore test/abort/.gitignore, because the newaddon test in there leaves a build/ folder lying around and somebody
is bound to use
git add .earlier or later.Refs: #31740
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes