doc: adjust paths in openssl maintenance guide#32593
Closed
hassaanp wants to merge 1 commit intonodejs:masterfrom
Closed
doc: adjust paths in openssl maintenance guide#32593hassaanp wants to merge 1 commit intonodejs:masterfrom
hassaanp wants to merge 1 commit intonodejs:masterfrom
Conversation
sam-github
approved these changes
Apr 1, 2020
Contributor
sam-github
left a comment
sam-github
left a comment
There was a problem hiding this comment.
Changes LGTM.
[ ] commit message follows commit guidelines
^--- please amend (git commit --amend ) your commit message, it is longer than 50 chars, and is not descriptive. I suggest:
doc: adjust paths in openssl maintenance guide
addaleax
approved these changes
Apr 1, 2020
Member
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
LGTM
Just to be clear, the commit message can also be updated by whoever merges this.
Contributor
@hassaanp, we can do that for you if you'd like, but you look like you are on track to becoming a consistent contributor, so its worth getting up to speed on how to use git to maintain your branches, and becoming familiar with the contribution guidelines. |
Contributor
Author
|
@sam-github - you are right. I will fix the commit and push it shortly. |
The path for the crypto files in the `deps/openssl/openssl/` after running `cd deps/openssl/config && make` has been changed. The original path `deps/openssl/openssl/crypto/includes/internal/` now maps to `deps/openssl/openssl/includes/crypto`for the files that need to be added for the commit.
hassaanp
force-pushed
the
doc/update-maintainence-guide-for-openssl
branch
from
5cf2a23 to
8ec3211
Compare
Contributor
Author
|
@sam-github applied your suggestion. |
sam-github
changed the title
jasnell
approved these changes
Apr 1, 2020
addaleax
added
the
author ready
trivikr
approved these changes
Apr 4, 2020
Member
|
Landed in a1b6ae6, thanks for the PR! |
addaleax
pushed a commit
that referenced
this pull request
Apr 5, 2020
The path for the crypto files in the `deps/openssl/openssl/` after running `cd deps/openssl/config && make` has been changed. The original path `deps/openssl/openssl/crypto/includes/internal/` now maps to `deps/openssl/openssl/includes/crypto`for the files that need to be added for the commit. PR-URL: #32593 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
The path for the crypto files in the `deps/openssl/openssl/` after running `cd deps/openssl/config && make` has been changed. The original path `deps/openssl/openssl/crypto/includes/internal/` now maps to `deps/openssl/openssl/includes/crypto`for the files that need to be added for the commit. PR-URL: #32593 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
The path for the crypto files in the `deps/openssl/openssl/` after running `cd deps/openssl/config && make` has been changed. The original path `deps/openssl/openssl/crypto/includes/internal/` now maps to `deps/openssl/openssl/includes/crypto`for the files that need to be added for the commit. PR-URL: #32593 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
The path for the crypto files in the `deps/openssl/openssl/` after running `cd deps/openssl/config && make` has been changed. The original path `deps/openssl/openssl/crypto/includes/internal/` now maps to `deps/openssl/openssl/includes/crypto`for the files that need to be added for the commit. PR-URL: #32593 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path for the crypto files in the
deps/openssl/openssl/after running
cd deps/openssl/config && makehas been changed.The original path
deps/openssl/openssl/crypto/includes/internal/now maps to
deps/openssl/openssl/includes/cryptofor the files thatneed to be added for the commit.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes