test: use common.mustCall in test-worker-esm-exit#32544
Closed
himself65 wants to merge 1 commit intonodejs:masterfrom
Closed
test: use common.mustCall in test-worker-esm-exit#32544himself65 wants to merge 1 commit intonodejs:masterfrom
himself65 wants to merge 1 commit intonodejs:masterfrom
Conversation
cjihrig
approved these changes
Mar 29, 2020
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM once the CI is happy.
himself65
force-pushed
the
20200329-test
branch
from
aae9f0d to
7a3d56a
Compare
addaleax
approved these changes
Mar 29, 2020
addaleax
added
the
author ready
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/30170/ (:heavy_check_mark:) |
Trott
approved these changes
Mar 30, 2020
lpinca
approved these changes
Mar 30, 2020
addaleax
pushed a commit
that referenced
this pull request
Apr 2, 2020
PR-URL: #32544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
|
Landed in 060a170 |
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
PR-URL: #32544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
PR-URL: #32544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32544 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes