Closed
Conversation
Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE Signed-off-by: James M Snell <jasnell@gmail.com>
Collaborator
antsmartian
approved these changes
Mar 25, 2020
himself65
reviewed
Mar 25, 2020
Member
himself65
left a comment
himself65
left a comment
There was a problem hiding this comment.
I saw many error messages on codes, for example
Lines 624 to 625 in afe3530
node/lib/internal/http2/core.js
Line 2856 in 66310c2
should we fix them at one time?
BTW, is there any solution prevents more error messages for the future?
Member
Author
|
Let's just tackle them incrementally. If nothing else it makes a good first contribution for new comers. They aren't critical changes so no need to do them all at once. |
Collaborator
jasnell
added
the
author ready
addaleax
approved these changes
Mar 27, 2020
addaleax
pushed a commit
that referenced
this pull request
Mar 27, 2020
Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32474 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Member
|
Landed in a057871 |
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32474 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #32474 Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use "cmd.action" instead of just "action" for ERR_INVALID_ARG_TYPE
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes