stream: fix pipeline with dest in objectMode#32414
Closed
ronag wants to merge 1 commit intonodejs:masterfrom
Closed
stream: fix pipeline with dest in objectMode#32414ronag wants to merge 1 commit intonodejs:masterfrom
ronag wants to merge 1 commit intonodejs:masterfrom
Conversation
lpinca
reviewed
Mar 23, 2020
lpinca
approved these changes
Mar 24, 2020
ronag
added
the
author ready
Collaborator
jasnell
approved these changes
Mar 24, 2020
trivikr
approved these changes
Mar 24, 2020
Collaborator
Member
Author
|
@nodejs/build unrelated failure in multiple different PRs? test.node-api/test_buffer/test |
Member
Not sure why you pinged build here as that's a code problem (failing check). From the stack trace and previously (#31061) that check is to with arraybuffers and backing stores. If it's occurring in multiple PR's that would suggest something has landed on master that has regressed. |
Collaborator
Collaborator
Collaborator
Collaborator
pipeline did not support destination with generator that does not return strings or buffers.
ronag
force-pushed
the
stream-pipeline-dest-objectmode
branch
from
965e6e1 to
ee3aa34
Compare
Collaborator
awibox
approved these changes
Mar 25, 2020
Member
Author
|
Landed in 05f1df5 |
ronag
added a commit
that referenced
this pull request
Mar 25, 2020
pipeline did not support destination with generator that does not return strings or buffers. PR-URL: #32414 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 25, 2020
pipeline did not support destination with generator that does not return strings or buffers. PR-URL: #32414 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pipeline did not support destination which is generator that does not return strings or buffers.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes