doc: tests local links in markdown documents#32359
Closed
aduh95 wants to merge 2 commits intonodejs:masterfrom
Closed
doc: tests local links in markdown documents#32359aduh95 wants to merge 2 commits intonodejs:masterfrom
aduh95 wants to merge 2 commits intonodejs:masterfrom
Conversation
nodejs-github-bot
added
build
addaleax
approved these changes
Mar 29, 2020
addaleax
added
the
author ready
Collaborator
Trott
approved these changes
Mar 30, 2020
Collaborator
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Member
|
Landed in 19db0e6 🎉 |
addaleax
pushed a commit
that referenced
this pull request
Mar 30, 2020
PR-URL: #32359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
2 tasks
mildsunrise
added a commit
that referenced
this pull request
Apr 2, 2020
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: #32359 PR-URL: #32586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Apr 7, 2020
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: #32359 PR-URL: #32586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 12, 2020
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: #32359 PR-URL: #32586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
PR-URL: #32359 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 22, 2020
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: #32359 PR-URL: #32586 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
abhishekumar-tyagi
pushed a commit
to abhishekumar-tyagi/node
that referenced
this pull request
May 5, 2024
- Test link definitions too - Report all broken links in a file, not just the first one - Avoid use of workers (launching ~90 workers has substantial overhead, and in my 4-core machine it is slower than not using them at all) & other simplifications Refs: nodejs/node#32359
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes MD files are moved around in the repo and it creates broken links. Unless I'm missing something, only
doc/apifiles are checked currently, this PR adds a test script for all other MD files to check image URLs and link targets.I have made an attempt to check HTTP links, but that was just taking too long so I have restricted to local links only.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes