Skip to content

test: uv_tty_init returns EBADF on IBM i#32338

Closed
dmabupt wants to merge 1 commit intonodejs:masterfrom
dmabupt:ibmi_tty
Closed

test: uv_tty_init returns EBADF on IBM i#32338
dmabupt wants to merge 1 commit intonodejs:masterfrom
dmabupt:ibmi_tty

Conversation

@dmabupt
Copy link
Contributor

@dmabupt dmabupt commented Mar 18, 2020

When TTY initialization failed, uv_tty_init returned EBADF on IBM i
PASE, rather than EINVAL

It resolves the test-ttywrap-invalid-fd test failure on IBM i --

python3 tools/test.py -J --mode=release -v test/parallel/test-ttywrap-invalid-fd.js 
# out/Release/node -p process.arch
# out/Release/node -p process.versions.openssl
# out/Release/node -p process.features.inspector
# out/Release/node -p process.versions.openssl
[00:00|%   0|+   0|-   0]: release test-ttywrap-invalid-fd# out/Release/node --expose-internals /git/node/test/parallel/test-ttywrap-invalid-fd.js
[00:01|% 100|+   1|-   0]: Done

@dmabupt
test: uv_tty_init returns EBADF on IBM i
3059108 
When TTY initialization failed, uv_tty_init returned EBADF on IBM i
PASE, rather than EINVAL
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 18, 2020
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 18, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29914/

@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 18, 2020
mhdawson
mhdawson approved these changes Mar 19, 2020
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Mar 19, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29937/

@mhdawson
Copy link
Member

mhdawson commented Mar 20, 2020

Last CI run looks ok: https://ci.nodejs.org/job/node-test-pull-request/29937/ even though status on PR does not reflect that. Going to land.

mhdawson pushed a commit that referenced this pull request Mar 20, 2020
@dmabupt @mhdawson
test: uv_tty_init returns EBADF on IBM i
b891e93 
When TTY initialization failed, uv_tty_init returned EBADF on IBM i
PASE, rather than EINVAL

PR-URL: #32338
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@mhdawson
Copy link
Member

mhdawson commented Mar 20, 2020

Landed in ee7e0ce

@mhdawson mhdawson closed this Mar 20, 2020
@dmabupt dmabupt deleted the ibmi_tty branch March 21, 2020 09:40
MylesBorins pushed a commit that referenced this pull request Mar 24, 2020
@dmabupt @MylesBorins
test: uv_tty_init returns EBADF on IBM i
4d173ea 
When TTY initialization failed, uv_tty_init returned EBADF on IBM i
PASE, rather than EINVAL

PR-URL: #32338
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@MylesBorins MylesBorins mentioned this pull request Mar 24, 2020
Merged
@dmabupt dmabupt mentioned this pull request Mar 26, 2020
Closed
targos pushed a commit that referenced this pull request Apr 22, 2020
@dmabupt @targos
test: uv_tty_init returns EBADF on IBM i
85ae566 
When TTY initialization failed, uv_tty_init returned EBADF on IBM i
PASE, rather than EINVAL

PR-URL: #32338
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@targos targos mentioned this pull request Apr 22, 2020
Merged
@dmabupt dmabupt mentioned this pull request May 29, 2020
Closed
richardlau pushed a commit that referenced this pull request Jun 1, 2020
@dmabupt @richardlau
test: uv_tty_init now returns EINVAL on IBM i
7774458 
Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.

PR-URL: #33629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 18, 2020
@dmabupt @codebytere
test: uv_tty_init now returns EINVAL on IBM i
15eb5a3 
Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.

PR-URL: #33629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Jun 30, 2020
@dmabupt @codebytere
test: uv_tty_init now returns EINVAL on IBM i
3a7b722 
Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.

PR-URL: #33629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
codebytere pushed a commit that referenced this pull request Jul 9, 2020
@dmabupt @codebytere
test: uv_tty_init now returns EINVAL on IBM i
0982bf4 
Since the PR libuv/libuv#2753
has been landed, we need to revert the code change in
PR #32338.

PR-URL: #33629
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees

No one assigned

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@dmabupt @nodejs-github-bot @mhdawson @bnoordhuis @jasnell @cjihrig @richardlau @BethGriggs