build: add commit message linting to workflow#32336
build: add commit message linting to workflow#32336richardlau wants to merge 1 commit intonodejs:masterfrom
Conversation
|
FYI this will not work because it is using GITHUB_TOKEN and Edit: this is easy to test by the way, change the commit message to something not following our guidelines :) |
Run linting on the commit message of the first commit in a pull request as part of our GitHub actions CI workflow. If linting fails the pull request will be labelled as requiring a fix to the commit message. The check itself will always pass so as to not concern first time contributors. Signed-off-by: Richard Lau <riclau@uk.ibm.com>
bba29c3 to
22838f6
Compare
Yes, you're right. https://github.com/nodejs/node/pull/32336/checks?check_run_id=515383424#step:5:9 Pity. |
Run linting on the commit message of the first commit in a pull
request as part of our GitHub actions CI workflow. If linting fails
the pull request will be labelled as requiring a fix to the commit
message. The check itself will always pass so as to not concern
first time contributors.
This is a different approach to the commit message linting that
is currently run on Travis CI. The new label introduced by this
pull request (
needs commit message fix) could also be addedmanually for cases where the commit message needs updating
before landing for things not caught by
core-validate-commit(e.g. typos). We can also teach
node-core-utilsto check for thelabel when landing pull requests (for those things not caught by
core-validate-commit).Checklist