test: mark test-timers-blocking-callback flaky on osx#32189
Closed
MylesBorins wants to merge 1 commit intonodejs:masterfrom
Closed
test: mark test-timers-blocking-callback flaky on osx#32189MylesBorins wants to merge 1 commit intonodejs:masterfrom
MylesBorins wants to merge 1 commit intonodejs:masterfrom
Conversation
This is only for 10.15 but this test is periodically failing across many CI runs. Would like to mark this as flaky so we can avoid lots of red CI. Refs: nodejs#21781
Contributor
Author
|
Can I get a fastrack? this is going to block 13.11.0 |
MylesBorins
added
the
fast-track
gireeshpunathil
approved these changes
Mar 11, 2020
BethGriggs
approved these changes
Mar 11, 2020
Contributor
Author
|
landed in e00e77e |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is only for 10.15 but this test is periodically failing across
many CI runs. Would like to mark this as flaky so we can avoid lots
of red CI.
Refs: #21781