doc: fix os.version() Windows API#32156
Conversation
|
I suggest adding the |
Honestly, I don't think Node should be calling out these implementation details. If anything, I'd direct users to the libuv docs. Not because the libuv docs are particularly good, but because Node uses libuv directly, and if implementation changes are made in libuv, the docs there are more likely to get updated properly. |
Yeah, I think you're right. I'm +1 on this. |
pRtlGetVersion is not a thing. This text was likely a result of copying the variable name used in libuv. This commit updates the documentation to reference the correct Windows API call. PR-URL: nodejs#32156 Refs: nodejs#31732 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
pRtlGetVersionis not a thing. This text was likely a result of copying the variable name used in libuv. This commit updates the documentation to reference the correct Windows API call.Refs: #31732
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes