src: revamp internal field count tracking#31960
Closed
jasnell wants to merge 1 commit intonodejs:masterfrom
Closed
src: revamp internal field count tracking#31960jasnell wants to merge 1 commit intonodejs:masterfrom
jasnell wants to merge 1 commit intonodejs:masterfrom
Conversation
nodejs-github-bot
added
c++
2 tasks
addaleax
reviewed
Feb 26, 2020
jasnell
force-pushed
the
revamp-internal-field-count-tracking
branch
from
39f07a2 to
ec851dc
Compare
addaleax
approved these changes
Feb 26, 2020
Collaborator
bnoordhuis
reviewed
Feb 26, 2020
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Thanks, this is already much better than the current state of things and looks like it already exposes a few infidelities and at least one outright bug.
addaleax
requested changes
Feb 26, 2020
2 tasks
addaleax
approved these changes
Feb 26, 2020
Collaborator
Collaborator
jasnell
added
the
author ready
fhinkel
approved these changes
Feb 27, 2020
bnoordhuis
approved these changes
Feb 28, 2020
Member
bnoordhuis
left a comment
bnoordhuis
left a comment
There was a problem hiding this comment.
Thanks, LGTM with suggestions.
Collaborator
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
revamp-internal-field-count-tracking
branch
from
aa26581 to
9c6e9cd
Compare
Collaborator
Collaborator
jasnell
added a commit
that referenced
this pull request
Mar 2, 2020
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Member
Author
|
Landed in 0fac393 |
MylesBorins
pushed a commit
that referenced
this pull request
Mar 4, 2020
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Member
|
Depends at least on #31569 to land on v12.x |
targos
removed
author ready
targos
pushed a commit
to targos/node
that referenced
this pull request
Apr 25, 2020
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
targos
pushed a commit
that referenced
this pull request
Apr 28, 2020
Change suggested by bnoordhuis. Improve handing of internal field counting by using enums. Helps protect against future possible breakage if field indexes are ever changed or added to. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #31960 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved handling of internal field counts.
In a separate PR, it would likely be good to switch to use of utility functions that include
DCHECKs for theInternalFieldCount()./cc @bnoordhuis @addaleax
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes