src: handle bad callback in asyc_wrap

[HarshithaKP]

src: handle bad callback in asyc_wrap

Align with the MaybeLocal<> API contract
Refs:

node/deps/v8/include/v8.h

Lines 345 to 349 in 9403250

	* If an API method returns a MaybeLocal<>, the API method can potentially fail
	* either because an exception is thrown, or because an exception is pending,
	* e.g. because a previous API call threw an exception that hasn't been caught
	* yet, or because a TerminateExecution exception was thrown. In that case, an
	* empty MaybeLocal is returned.

addresses an @addaleax 's TODO

src: elevate v8 namespaces

Checklist

• make -j4 test (UNIX), or vcbuild test (Windows) passes
• tests and/or benchmarks are included
• documentation is changed or added
• commit message follows commit guidelines

[addaleax]

We don’t add using statements to headers (we should probably have a linter rule against that, at least for the v8 symbols…)

[HarshithaKP]

@addaleax, grep "using v8::" src/*.h

I am seeing this pattern in few files already. If I remove using phrase, is there any way I can elevate ?

[addaleax]

Yes, these other files should also not use it.

There are no shorthands in that case, we do spell out the entire type in headers.

[HarshithaKP]

@addaleax,thanks. Reverted the changes. What is the rationale for this ?

[HarshithaKP]

I mean, why we want to skip for headers ? Is there any performance reason or something else ?

[addaleax]

@HarshithaKP Because then the symbols are available in any source file that includes this header, even if that’s not obvious. For example, this code would fail to compile if example.h has a using v8::Array; line:

#include "example.h"

class Array {};

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/29533/

[gireeshpunathil]

landed in 757e203