Skip to content

benchmark: reland test refactoring#31755

Closed
BridgeAR wants to merge 6 commits intonodejs:masterfrom
BridgeAR:2020-02-12-reland-benchmark-test-refactoring
Closed

benchmark: reland test refactoring#31755
BridgeAR wants to merge 6 commits intonodejs:masterfrom
BridgeAR:2020-02-12-reland-benchmark-test-refactoring

Conversation

@BridgeAR
Copy link
Member

@BridgeAR BridgeAR commented Feb 12, 2020

#31396 was reverted in #31722. The issue was that WRK is not able to handle decimal times (and the minimum possible time is one second) and the threads must not be higher than the number of connections.

I just reverted the revert and added a fixup commit to fix the actual issue. The commit message might be changed during landing?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@BridgeAR BridgeAR requested a review from addaleax February 12, 2020 20:04
@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. crypto Issues and PRs related to the crypto subsystem. http Issues or PRs related to the http subsystem. v8 engine Issues and PRs related to the V8 dependency. labels Feb 12, 2020
@BridgeAR BridgeAR force-pushed the 2020-02-12-reland-benchmark-test-refactoring branch from 4bbf411 to 0074942 Compare February 12, 2020 20:05
@BridgeAR BridgeAR requested review from Trott and sam-github February 12, 2020 22:03
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 12, 2020

CI: https://ci.nodejs.org/job/node-test-pull-request/29088/

@addaleax
Copy link
Member

addaleax commented Feb 12, 2020 •
edited by BridgeAR
Loading

Benchmark test CI: https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12163/ ✔️

mscdex
mscdex reviewed Feb 12, 2020
View reviewed changes
@BridgeAR
Copy link
Member Author

BridgeAR commented Feb 13, 2020

Benchmark CI https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12185/

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 13, 2020
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
@addaleax
Copy link
Member

addaleax commented Mar 9, 2020

This needs a rebase.

@BridgeAR BridgeAR force-pushed the 2020-02-12-reland-benchmark-test-refactoring branch from 5b12cbc to 778b2a6 Compare March 9, 2020 13:10
@BridgeAR
Copy link
Member Author

BridgeAR commented Mar 9, 2020 •
edited
Loading

CI https://ci.nodejs.org/job/node-test-commit-custom-suites-freestyle/12703/ ✔️

@BridgeAR BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 9, 2020
BridgeAR added a commit that referenced this pull request Mar 9, 2020
@BridgeAR
benchmark: refactor helper into a class
f64aafa 
This reverts commit 5b0308c.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
@BridgeAR
benchmark: add test and all options and improve errors"
1760c23 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
@BridgeAR
test: refactor all benchmark tests to use the new test option
9e40df7 
This reverts commit aa0a01b.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
BridgeAR added a commit that referenced this pull request Mar 9, 2020
@BridgeAR
benchmark: remove special test entries
bb6125b 
This reverts commit 7cfbc9f.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BridgeAR
Copy link
Member Author

BridgeAR commented Mar 9, 2020

Landed in 9e69d97...bb6125b 🎉

@BridgeAR BridgeAR closed this Mar 9, 2020
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@BridgeAR @MylesBorins
benchmark: refactor helper into a class
e11f38c 
This reverts commit 5b0308c.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@BridgeAR @MylesBorins
benchmark: add test and all options and improve errors"
5d92cec 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@BridgeAR @MylesBorins
test: refactor all benchmark tests to use the new test option
92cc406 
This reverts commit aa0a01b.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2020
@BridgeAR @MylesBorins
benchmark: remove special test entries
ddb8824 
This reverts commit 7cfbc9f.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 10, 2020
Merged
@targos targos added backport-blocked-v12.x and removed author ready PRs that have at least one approval, no pending requests for changes, and a CI started. backport-blocked-v12.x labels Apr 20, 2020
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
benchmark: refactor helper into a class
900cf06 
This reverts commit 5b0308c.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
benchmark: add test and all options and improve errors"
51e2427 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
test: refactor all benchmark tests to use the new test option
8e59077 
This reverts commit aa0a01b.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit to targos/node that referenced this pull request Apr 25, 2020
@BridgeAR @targos
benchmark: remove special test entries
1b0b817 
This reverts commit 7cfbc9f.

PR-URL: nodejs#31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
benchmark: refactor helper into a class
011e3de 
This reverts commit 5b0308c.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
benchmark: add test and all options and improve errors"
7139788 
This reverts commit 4671d55 and
contains a fix to the issue raised for the revert.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
test: refactor all benchmark tests to use the new test option
5a8e54b 
This reverts commit aa0a01b.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Apr 28, 2020
@BridgeAR @targos
benchmark: remove special test entries
b4a6351 
This reverts commit 7cfbc9f.

PR-URL: #31755
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 2, 2020
Merged
@lundibundi lundibundi mentioned this pull request Sep 3, 2020
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Trott Trott Trott approved these changes

@addaleax addaleax addaleax approved these changes

@sam-github sam-github Awaiting requested review from sam-github

+2 more reviewers

@mscdex mscdex mscdex left review comments

@vdeturckheim vdeturckheim vdeturckheim approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

assert Issues and PRs related to the assert subsystem. async_hooks Issues and PRs related to the async hooks subsystem. benchmark Issues and PRs related to the benchmark subsystem. buffer Issues and PRs related to the buffer subsystem. crypto Issues and PRs related to the crypto subsystem. http Issues or PRs related to the http subsystem. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@BridgeAR @nodejs-github-bot @addaleax @mscdex @Trott @vdeturckheim @targos