Skip to content

[v10.x] deps: V8: cherry-pick d89f4ef1cd62#31753

Closed
miladfarca wants to merge 1 commit intonodejs:v10.x-stagingfrom
miladfarca:patch
Closed

[v10.x] deps: V8: cherry-pick d89f4ef1cd62#31753
miladfarca wants to merge 1 commit intonodejs:v10.x-stagingfrom
miladfarca:patch

Conversation

@miladfarca
Copy link
Contributor

@miladfarca miladfarca commented Feb 12, 2020

Original commit message:

S390x: improve performance by skipping Debug Hook if not needed

Change-Id: Ib4b2821f2941cdc131f9c75b89a3baced7554f8d
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/1991802
Reviewed-by: Junliang Yan <jyan@ca.ibm.com>
Commit-Queue: Milad Farazmand <miladfar@ca.ibm.com>
Cr-Commit-Position: refs/heads/master@{#65644}

Refs: v8/v8@d89f4ef

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. v10.x v8 engine Issues and PRs related to the V8 dependency. labels Feb 12, 2020
@miladfarca
Copy link
Contributor Author

miladfarca commented Feb 12, 2020

/cc @nodejs/platform-s390

bnoordhuis
bnoordhuis reviewed Feb 13, 2020
View reviewed changes
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Feb 26, 2020 •
edited by BethGriggs
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/29371/ ✅

@BethGriggs
Copy link
Member

BethGriggs commented Feb 26, 2020

Landed in 9b2b66b

@BethGriggs BethGriggs closed this Feb 26, 2020
BethGriggs pushed a commit that referenced this pull request Feb 26, 2020
@BethGriggs
deps: V8: cherry-pick d89f4ef1cd62
9b2b66b 
PR-URL: #31753
Refs: v8/v8@d89f4ef
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BethGriggs BethGriggs mentioned this pull request Mar 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

+1 more reviewer

@john-yan john-yan john-yan left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build Issues and PRs related to build files or the CI. v8 engine Issues and PRs related to the V8 dependency.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miladfarca @nodejs-github-bot @BethGriggs @bnoordhuis @john-yan @richardlau