doc: add AsyncResource + Worker pool example#31601
Closed
addaleax wants to merge 3 commits intonodejs:masterfrom
Closed
doc: add AsyncResource + Worker pool example#31601addaleax wants to merge 3 commits intonodejs:masterfrom
addaleax wants to merge 3 commits intonodejs:masterfrom
Conversation
Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks.
addaleax
added
async_hooks
Member
Author
|
@nodejs/async_hooks |
gireeshpunathil
approved these changes
Feb 1, 2020
jasnell
approved these changes
Feb 1, 2020
legendecas
approved these changes
Feb 2, 2020
|
Hi @addaleax , @gireeshpunathil , Thanks !!! |
Trott
reviewed
Feb 3, 2020
Trott
approved these changes
Feb 3, 2020
Member
Trott
left a comment
Trott
left a comment
There was a problem hiding this comment.
LGTM with or without my suggestion.
addaleax
added
the
author ready
Co-Authored-By: Rich Trott <rtrott@gmail.com>
antsmartian
approved these changes
Feb 5, 2020
Member
Author
|
Landed in 6a6279e |
addaleax
added a commit
that referenced
this pull request
Feb 5, 2020
Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: #31601 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Feb 17, 2020
Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: #31601 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
Member
|
Blocked on #32131 |
Member
Author
|
@codebytere … why? This is about |
Member
|
@addaleax my fault, wrong label! you're right. This is a conflict but it just needs a manual backport. |
Member
Author
|
@codebytere It backports cleanly for me… I can just push to v12.x-staging if you like? |
codebytere
pushed a commit
that referenced
this pull request
Mar 17, 2020
Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: #31601 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Merged
codebytere
pushed a commit
that referenced
this pull request
Mar 23, 2020
Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: #31601 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
codebytere
pushed a commit
that referenced
this pull request
Mar 30, 2020
Use Worker thread pools as an example of how `AsyncResource` can be used to track async state across callbacks. PR-URL: #31601 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use Worker thread pools as an example of how
AsyncResourcecan be used to track async state across callbacks.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes