readline: make tab size configurable by BridgeAR · Pull Request #31318 · nodejs/node

BridgeAR · 2020-01-11T19:10:51Z

This adds the tabSize option to readline to allow different tab
sizes. It also cleans up some code and unifies the linebreak RegExp.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

bnoordhuis

The historySize changes should be a separate commit and arguably a separate PR because it's unrelated.

lib/readline.js

BridgeAR · 2020-01-12T20:18:28Z

@bnoordhuis I removed the refactoring.

nodejs-github-bot · 2020-01-12T23:10:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28419/ ✔️

BridgeAR · 2020-01-13T08:05:58Z

@nodejs/readline @nodejs/repl PTAL (this is the basis to add the same option to the repl).

test/parallel/test-readline-interface.js

Trott · 2020-01-14T05:11:49Z

Not opposed to this, but curious what the motivation is. Is this something you've needed but didn't have? Is it something someone has asked for?

BridgeAR · 2020-01-14T07:47:10Z

@Trott neither. The reason is that it's possible to change the tab size in terminals.

BridgeAR · 2020-01-17T08:00:37Z

@nodejs/repl @nodejs/readline this could use some reviews.

mcollina

I would prefer if this did not edit existings tests as well, it makes the review harder.

BridgeAR · 2020-01-20T13:37:26Z

I updated the tests to be independent but I want to note that we just copy 95% of the test code all the time.

nodejs-github-bot · 2020-01-20T14:03:15Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28496/

nodejs-github-bot · 2020-01-20T18:12:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28511/

nodejs-github-bot · 2020-01-20T22:49:28Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28521/

lib/readline.js

nodejs-github-bot · 2020-01-22T15:00:50Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28562/

nodejs-github-bot · 2020-01-25T09:42:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28633/

nodejs-github-bot · 2020-01-26T18:28:54Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28697/

nodejs-github-bot · 2020-01-26T19:00:34Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28698/

nodejs-github-bot · 2020-01-26T19:56:23Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28701/

nodejs-github-bot · 2020-01-27T06:39:49Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28710/

nodejs-github-bot · 2020-02-05T12:22:36Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28934/

addaleax

This needs a rebase

This adds the `tabSize` option to readline to allow different tab sizes.

nodejs-github-bot · 2020-02-06T19:49:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28957/

nodejs-github-bot · 2020-02-06T22:40:51Z

CI: https://ci.nodejs.org/job/node-test-pull-request/28962/

This adds the `tabSize` option to readline to allow different tab sizes. PR-URL: #31318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

addaleax · 2020-02-07T11:38:28Z

Landed in f9a27ea

This adds the `tabSize` option to readline to allow different tab sizes. PR-URL: #31318 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable changes: * async_hooks * add executionAsyncResource (Matteo Collina) #30959 * crypto * add crypto.diffieHellman (Tobias Nießen) #31178 * add DH support to generateKeyPair (Tobias Nießen) #31178 * simplify DH groups (Tobias Nießen) #31178 * add key type 'dh' (Tobias Nießen) #31178 * test * skip keygen tests on arm systems (Tobias Nießen) #31178 * perf_hooks * add property flags to GCPerformanceEntry (Kirill Fomichev) #29547 * process * report ArrayBuffer memory in `memoryUsage()` (Anna Henningsen) #31550 * readline * make tab size configurable (Ruben Bridgewater) #31318 * report * add support for Workers (Anna Henningsen) #31386 * worker * add ability to take heap snapshot from parent thread (Anna Henningsen) #31569 * added new collaborators * add ronag to collaborators (Robert Nagy) #31498 PR-URL: #31837

targos · 2020-04-25T20:21:29Z

Depends on #31423 to land on v12.x

nodejs-github-bot added the readline Issues and PRs related to the built-in readline module. label Jan 11, 2020

BridgeAR added the semver-minor PRs that contain new features and should be released in the next minor version. label Jan 11, 2020

This comment has been minimized.

Sign in to view

bnoordhuis reviewed Jan 12, 2020

View reviewed changes

lib/readline.js Outdated Show resolved Hide resolved

This comment has been minimized.

Sign in to view

BridgeAR force-pushed the 2020-01-11-readline-make-tab-size-configurable branch from 60f32a5 to 77effd2 Compare January 12, 2020 20:14

BridgeAR force-pushed the 2020-01-11-readline-make-tab-size-configurable branch from 77effd2 to 5f1947d Compare January 12, 2020 21:04

This comment has been minimized.

Sign in to view

Trott reviewed Jan 14, 2020

View reviewed changes

test/parallel/test-readline-interface.js Outdated Show resolved Hide resolved

BridgeAR requested review from jasnell, lundibundi, mcollina and targos January 20, 2020 11:16

mcollina reviewed Jan 20, 2020

View reviewed changes

jasnell approved these changes Jan 20, 2020

View reviewed changes

BridgeAR added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 20, 2020

lundibundi approved these changes Jan 20, 2020

View reviewed changes

antsmartian approved these changes Jan 21, 2020

View reviewed changes

lib/readline.js Outdated Show resolved Hide resolved

BridgeAR force-pushed the 2020-01-11-readline-make-tab-size-configurable branch from d7eddc1 to 0b9ec1d Compare January 22, 2020 14:58

Trott approved these changes Jan 27, 2020

View reviewed changes

addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Feb 5, 2020

addaleax approved these changes Feb 5, 2020

View reviewed changes

BridgeAR force-pushed the 2020-01-11-readline-make-tab-size-configurable branch from 0b9ec1d to 27983d4 Compare February 6, 2020 19:46

readline: make tab size configurable

c7571e2

This adds the `tabSize` option to readline to allow different tab sizes.

BridgeAR force-pushed the 2020-01-11-readline-make-tab-size-configurable branch from 27983d4 to c7571e2 Compare February 6, 2020 19:48

addaleax closed this Feb 7, 2020

codebytere mentioned this pull request Feb 17, 2020

v13.9.0 proposal #31837

Merged

targos mentioned this pull request Apr 18, 2020

readline: remove intermediate variable #31676

Merged

2 tasks

targos added the backport-blocked-v12.x label Apr 25, 2020

addaleax added dont-land-on-v12.x and removed backport-blocked-v12.x labels Sep 23, 2020

Uh oh!

Conversation

BridgeAR commented Jan 11, 2020

Checklist

Uh oh!

This comment has been minimized.

This comment has been minimized.

bnoordhuis left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

This comment has been minimized.

BridgeAR commented Jan 12, 2020

Uh oh!

This comment has been minimized.

nodejs-github-bot commented Jan 12, 2020 • edited by BridgeAR Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Jan 13, 2020

Uh oh!

Uh oh!

Trott commented Jan 14, 2020

Uh oh!

BridgeAR commented Jan 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

BridgeAR commented Jan 17, 2020

Uh oh!

mcollina left a comment

Choose a reason for hiding this comment

Uh oh!

BridgeAR commented Jan 20, 2020

Uh oh!

nodejs-github-bot commented Jan 20, 2020

Uh oh!

nodejs-github-bot commented Jan 20, 2020

Uh oh!

nodejs-github-bot commented Jan 20, 2020

Uh oh!

Uh oh!

nodejs-github-bot commented Jan 22, 2020

Uh oh!

nodejs-github-bot commented Jan 25, 2020

Uh oh!

nodejs-github-bot commented Jan 26, 2020

Uh oh!

nodejs-github-bot commented Jan 26, 2020

Uh oh!

nodejs-github-bot commented Jan 26, 2020

Uh oh!

nodejs-github-bot commented Jan 27, 2020

Uh oh!

nodejs-github-bot commented Feb 5, 2020

Uh oh!

addaleax left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Feb 6, 2020

Uh oh!

nodejs-github-bot commented Feb 6, 2020

Uh oh!

addaleax commented Feb 7, 2020

Uh oh!

targos commented Apr 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

nodejs-github-bot commented Jan 12, 2020 •

edited by BridgeAR

Loading

BridgeAR commented Jan 14, 2020 •

edited

Loading